chore: updates to changelog before v1.0.0-rc.1 release#3253
Merged
Conversation
This was referenced Jun 12, 2024
cason
reviewed
Jun 14, 2024
cason
left a comment
There was a problem hiding this comment.
I don't have much background to understand this, but suggestions:
- Could we have a Table of Contents?
- Shouldn't updates be classified by "big" releases?
- Why unreleased stuff is on the changelog?
sergio-mena
reviewed
Jun 19, 2024
sergio-mena
reviewed
Jun 19, 2024
sergio-mena
reviewed
Jun 19, 2024
sergio-mena
reviewed
Jun 19, 2024
…dating CHANGELOG.md (#3253)
Collaborator
Author
|
@sergio-mena I've added the changes requested. In the last commits I've added these changes:
|
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
sergio-mena
reviewed
Jun 20, 2024
sergio-mena
reviewed
Jun 20, 2024
sergio-mena
reviewed
Jun 20, 2024
sergio-mena
approved these changes
Jun 20, 2024
Collaborator
sergio-mena
left a comment
There was a problem hiding this comment.
Amazing 🚀, thanks @andynog !
Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Sergio Mena <sergio@informal.systems>
mergify bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
Partially close: #3255 This PR updates the `CHANGELOG.md` file with the unreleased information updated before the `v1.0.0-rc.1` release cut (not that there's no `v1.0.0-rc.1` release in the changelog, this will happen only when we cut `v1.0.0` major release, no `unclog release` command was executed) The changelog was updated using the command: ``` unclog build -a > CHANGELOG.md ``` This PR also includes a change in the unclog `config.toml` to sort entries by `id` since this seem to be the old behavior and it's easier to diff the file with the historical `CHANGELOG.md` (otherwise it would be sorted alphabetically and this change in ordering for the past releases which is can be very confusing to diff and compare). #### PR checklist - [ ] Tests written/updated - [X] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [X] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> Co-authored-by: Sergio Mena <sergio@informal.systems> (cherry picked from commit f4c622f) # Conflicts: # .changelog/unreleased/breaking-changes/2786-remove-cleveldb-boltdb.md # .changelog/unreleased/breaking-changes/2892-remove-skip-timeout-commit.md # .changelog/unreleased/breaking-changes/2895-merge-timeout-prevote-precommit.md # .changelog/unreleased/breaking-changes/3248-crypto-sha256.md # .changelog/unreleased/improvements/1958-disable-linting.md # .changelog/unreleased/improvements/3016-remove-expensive-calls-from-flowrate.md # .changelog/unreleased/improvements/3056-export-node-package-errors.md # .changelog/unreleased/improvements/3117-significantly-speedup-make-partset.md # .changelog/unreleased/improvements/3119-speedup-valset-GetByAddress-usages.md # .changelog/unreleased/improvements/3156-make-addvote-only-take-one-ps-mtx.md # .changelog/unreleased/improvements/3159-fix-taking-wlocks-instead-of-rlocks.md # .changelog/unreleased/improvements/3162-reuse-internal-buffer-for-block-building.md # .changelog/unreleased/improvements/3180-lower-broadcasts-consensus-overhead.md # .changelog/unreleased/summary.md # CHANGELOG.md
4 tasks
andynog
added a commit
that referenced
this pull request
Jun 20, 2024
andynog
added a commit
that referenced
this pull request
Jun 20, 2024
… (#3312) Partially close: #3255 This PR updates the `CHANGELOG.md` file with the unreleased information updated before the `v1.0.0-rc.1` release cut (not that there's no `v1.0.0-rc.1` release in the changelog, this will happen only when we cut `v1.0.0` major release, no `unclog release` command was executed) The changelog was updated using the command: ``` unclog build -a > CHANGELOG.md ``` This PR also includes a change in the unclog `config.toml` to sort entries by `id` since this seem to be the old behavior and it's easier to diff the file with the historical `CHANGELOG.md` (otherwise it would be sorted alphabetically and this change in ordering for the past releases which is can be very confusing to diff and compare). #### PR checklist - [ ] Tests written/updated - [X] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [X] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3253 done by [Mergify](https://mergify.com). --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially close: #3255
This PR updates the
CHANGELOG.mdfile with the unreleased information updated before thev1.0.0-rc.1release cut (not that there's nov1.0.0-rc.1release in the changelog, this will happen only when we cutv1.0.0major release, nounclog releasecommand was executed)The changelog was updated using the command:
This PR also includes a change in the unclog
config.tomlto sort entries byidsince this seem to be the old behavior and it's easier to diff the file with the historicalCHANGELOG.md(otherwise it would be sorted alphabetically and this change in ordering for the past releases which is can be very confusing to diff and compare).PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments