Skip to content

chore: updates to changelog before v1.0.0-rc.1 release#3253

Merged
andynog merged 17 commits intomainfrom
andy/changelog-rc1-unreleased
Jun 20, 2024
Merged

chore: updates to changelog before v1.0.0-rc.1 release#3253
andynog merged 17 commits intomainfrom
andy/changelog-rc1-unreleased

Conversation

@andynog
Copy link
Collaborator

@andynog andynog commented Jun 12, 2024

Partially close: #3255

This PR updates the CHANGELOG.md file with the unreleased information updated before the v1.0.0-rc.1 release cut (not that there's no v1.0.0-rc.1 release in the changelog, this will happen only when we cut v1.0.0 major release, no unclog release command was executed)

The changelog was updated using the command:

unclog build -a > CHANGELOG.md 

This PR also includes a change in the unclog config.toml to sort entries by id since this seem to be the old behavior and it's easier to diff the file with the historical CHANGELOG.md (otherwise it would be sorted alphabetically and this change in ordering for the past releases which is can be very confusing to diff and compare).

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

@andynog andynog requested a review from a team as a code owner June 12, 2024 18:11
@andynog andynog requested a review from a team June 12, 2024 18:11
@andynog andynog self-assigned this Jun 12, 2024
@andynog andynog added release Pull requests that facilitate cutting a release backport-to-v1.x labels Jun 12, 2024
@andynog andynog added this to the 2024-Q2 milestone Jun 12, 2024
Copy link
Collaborator

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@cason cason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much background to understand this, but suggestions:

  • Could we have a Table of Contents?
  • Shouldn't updates be classified by "big" releases?
  • Why unreleased stuff is on the changelog?

@andynog andynog requested review from cason, melekes and sergio-mena June 19, 2024 19:57
@andynog
Copy link
Collaborator Author

andynog commented Jun 19, 2024

@sergio-mena I've added the changes requested. In the last commits I've added these changes:

  • Re-added the summary.md doc.
  • Removed releases that should not be in the .changelog folder. I've ensured that these entries matched the entries in their respective releases (folder diff) so we are not loosing anything.
  • Many formatting fixes and adding information that was missing to ensure entries are consistent and accurate.
  • Re-generated the CHANGELOG.md file after these changes were in place.

Copy link
Collaborator

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Copy link
Collaborator

@sergio-mena sergio-mena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🚀, thanks @andynog !

andynog and others added 6 commits June 20, 2024 13:59
Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Sergio Mena <sergio@informal.systems>
@andynog andynog added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit f4c622f Jun 20, 2024
@andynog andynog deleted the andy/changelog-rc1-unreleased branch June 20, 2024 18:35
mergify bot pushed a commit that referenced this pull request Jun 20, 2024
Partially close: #3255

This PR updates the `CHANGELOG.md` file with the unreleased information
updated before the `v1.0.0-rc.1` release cut (not that there's no
`v1.0.0-rc.1` release in the changelog, this will happen only when we
cut `v1.0.0` major release, no `unclog release` command was executed)

The changelog was updated using the command:
```
unclog build -a > CHANGELOG.md
```

This PR also includes a change in the unclog `config.toml` to sort
entries by `id` since this seem to be the old behavior and it's easier
to diff the file with the historical `CHANGELOG.md` (otherwise it would
be sorted alphabetically and this change in ordering for the past
releases which is can be very confusing to diff and compare).

#### PR checklist

- [ ] Tests written/updated
- [X] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [X] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

---------

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Sergio Mena <sergio@informal.systems>
(cherry picked from commit f4c622f)

# Conflicts:
#	.changelog/unreleased/breaking-changes/2786-remove-cleveldb-boltdb.md
#	.changelog/unreleased/breaking-changes/2892-remove-skip-timeout-commit.md
#	.changelog/unreleased/breaking-changes/2895-merge-timeout-prevote-precommit.md
#	.changelog/unreleased/breaking-changes/3248-crypto-sha256.md
#	.changelog/unreleased/improvements/1958-disable-linting.md
#	.changelog/unreleased/improvements/3016-remove-expensive-calls-from-flowrate.md
#	.changelog/unreleased/improvements/3056-export-node-package-errors.md
#	.changelog/unreleased/improvements/3117-significantly-speedup-make-partset.md
#	.changelog/unreleased/improvements/3119-speedup-valset-GetByAddress-usages.md
#	.changelog/unreleased/improvements/3156-make-addvote-only-take-one-ps-mtx.md
#	.changelog/unreleased/improvements/3159-fix-taking-wlocks-instead-of-rlocks.md
#	.changelog/unreleased/improvements/3162-reuse-internal-buffer-for-block-building.md
#	.changelog/unreleased/improvements/3180-lower-broadcasts-consensus-overhead.md
#	.changelog/unreleased/summary.md
#	CHANGELOG.md
andynog added a commit that referenced this pull request Jun 20, 2024
andynog added a commit that referenced this pull request Jun 20, 2024
… (#3312)

Partially close: #3255

This PR updates the `CHANGELOG.md` file with the unreleased information
updated before the `v1.0.0-rc.1` release cut (not that there's no
`v1.0.0-rc.1` release in the changelog, this will happen only when we
cut `v1.0.0` major release, no `unclog release` command was executed)

The changelog was updated using the command:
```
unclog build -a > CHANGELOG.md 
```

This PR also includes a change in the unclog `config.toml` to sort
entries by `id` since this seem to be the old behavior and it's easier
to diff the file with the historical `CHANGELOG.md` (otherwise it would
be sorted alphabetically and this change in ordering for the past
releases which is can be very confusing to diff and compare).

#### PR checklist

- [ ] Tests written/updated
- [X] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [X] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
<hr>This is an automatic backport of pull request #3253 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Pull requests that facilitate cutting a release

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

chore: preparation for first release candidate v1.0.0-rc1

4 participants