revert(internal): Implement ADR 114 by making several modules public again#3004
Merged
revert(internal): Implement ADR 114 by making several modules public again#3004
Conversation
The url was wrongly referring to state/indexer, not indexer leading to wrong results in the table.
adizere
commented
May 4, 2024
Comment on lines
+98
to
+99
| | evidence | keep private | 1 | 26 | high | [evidence-url] | | ||
| | consensus | keep private | 1 | 64 | high | [consensus-url] | |
Contributor
Author
There was a problem hiding this comment.
See the remark below in this document
For
evidenceandconsensus: There is a single project we have identified using APIs from these modules,
specifically https://github.com/forbole/juno. The maintainers of this project have agreed it is not a problem
for them if we keep the two modules private.
| | bits | keep private | 0 | 26 | low | [bits-url] | | ||
| | blocksync | keep private | 0 | 6 | low | [blocksync-url] | | ||
| | clist | keep private | 0 | 24 | low | [clist-url] | | ||
| | indexer | keep private | 0 | 0 | low | [indexer-url] | |
Contributor
Author
There was a problem hiding this comment.
The indexer module has 0 public uses, so it doesn't need to become public again. We can keep it internal.
mergify bot
pushed a commit
that referenced
this pull request
May 6, 2024
…again (#3004) <!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> Closes #2990 --- The following modules are no longer in `internal`: - [x] `libs/pubsub` - [x] `libs/protoio` - [x] `libs/service` - [x] `libs/sync` - [x] `statesync` We also: - [x] added "XXX deprecated" marker in the above modules - [x] undid the .changelog entry that stated these modules are "Move to `internal`", since that is no longer true #### PR checklist - [ ] ~~Tests written/updated~~ - [ ] ~~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~~ - [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code comments~~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> (cherry picked from commit 34e5c05) # Conflicts: # rpc/core/tx.go
Merged
11 tasks
melekes
added a commit
that referenced
this pull request
May 6, 2024
…again (backport #3004) (#3011) Closes #2990 --- The following modules are no longer in `internal`: - [x] `libs/pubsub` - [x] `libs/protoio` - [x] `libs/service` - [x] `libs/sync` - [x] `statesync` We also: - [x] added "XXX deprecated" marker in the above modules - [x] undid the .changelog entry that stated these modules are "Move to `internal`", since that is no longer true #### PR checklist - [ ] ~~Tests written/updated~~ - [ ] ~~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~~ - [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code comments~~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3004 done by [Mergify](https://mergify.com). --------- Co-authored-by: Adi Seredinschi <adizere@gmail.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2990
The following modules are no longer in
internal:libs/pubsublibs/protoiolibs/servicelibs/syncstatesyncWe also:
internal", since that is no longer truePR checklist
Tests written/updatedChangelog entry added in.changelog(we use unclog to manage our changelog)Updated relevant documentation (docs/orspec/) and code comments