Conversation
…Meta (#2964) <!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> Our gossip block parts routine calls `Blockstore.LoadBlockMeta` (as do things in blocksync). This currently takes some time due to ValidateBasic:  However note that we only save validated data to the blockstore. We only do it in: - Commit: https://github.com/cometbft/cometbft/blob/main/internal/consensus/state.go#L1867 - Blocksync after validation: https://github.com/cometbft/cometbft/blob/main/internal/consensus/state.go#L1867 Hence the validate basic time is wasted. This should eventually just go to an LRU cache to even avoid the proto unmarshalling (as should ~everything in blockstore) but we want this anyway to reduce the computational overhead, WRT live consensus, in main this only helps with catchup for live syncing nodes, I haven't checked on v0.47.x, but the cpuprofile suggests it may help with active block gossip time as well? --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit 5601db6) # Conflicts: # store/store.go
Contributor
Author
|
Cherry-pick of 5601db6 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
melekes
approved these changes
May 3, 2024
ValarDragon
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 4, 2024
…Meta (backport cometbft#2964) (cometbft#2998) Our gossip block parts routine calls `Blockstore.LoadBlockMeta` (as do things in blocksync). This currently takes some time due to ValidateBasic:  However note that we only save validated data to the blockstore. We only do it in: - Commit: https://github.com/cometbft/cometbft/blob/main/internal/consensus/state.go#L1867 - Blocksync after validation: https://github.com/cometbft/cometbft/blob/main/internal/consensus/state.go#L1867 Hence the validate basic time is wasted. This should eventually just go to an LRU cache to even avoid the proto unmarshalling (as should ~everything in blockstore) but we want this anyway to reduce the computational overhead, WRT live consensus, in main this only helps with catchup for live syncing nodes, I haven't checked on v0.47.x, but the cpuprofile suggests it may help with active block gossip time as well? --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request cometbft#2964 done by [Mergify](https://mergify.com). --------- Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
ValarDragon
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 7, 2024
…Meta (backport cometbft#2964) (cometbft#2998) Our gossip block parts routine calls `Blockstore.LoadBlockMeta` (as do things in blocksync). This currently takes some time due to ValidateBasic:  However note that we only save validated data to the blockstore. We only do it in: - Commit: https://github.com/cometbft/cometbft/blob/main/internal/consensus/state.go#L1867 - Blocksync after validation: https://github.com/cometbft/cometbft/blob/main/internal/consensus/state.go#L1867 Hence the validate basic time is wasted. This should eventually just go to an LRU cache to even avoid the proto unmarshalling (as should ~everything in blockstore) but we want this anyway to reduce the computational overhead, WRT live consensus, in main this only helps with catchup for live syncing nodes, I haven't checked on v0.47.x, but the cpuprofile suggests it may help with active block gossip time as well? --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request cometbft#2964 done by [Mergify](https://mergify.com). --------- Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Merged
7 tasks
PaddyMc
pushed a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 22, 2024
…Meta (backport cometbft#2964) (cometbft#2998) (#62) * perf(consensus/blockstore): Remove validate basic call from LoadBlockMeta (cometbft#2998) (#62) Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
mergify bot
pushed a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 22, 2024
…Meta (backport cometbft#2964) (cometbft#2998) (#62) * perf(consensus/blockstore): Remove validate basic call from LoadBlockMeta (cometbft#2998) (#62) Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> (cherry picked from commit c73455f)
7 tasks
PaddyMc
pushed a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 23, 2024
…Meta (backport cometbft#2964) (cometbft#2998) (#62) (#66) * perf(consensus/blockstore): Remove validate basic call from LoadBlockMeta (cometbft#2998) (#62) Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> (cherry picked from commit c73455f) Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our gossip block parts routine calls
Blockstore.LoadBlockMeta(as do things in blocksync). This currently takes some time due to ValidateBasic:However note that we only save validated data to the blockstore. We only do it in:
Hence the validate basic time is wasted.
This should eventually just go to an LRU cache to even avoid the proto unmarshalling (as should ~everything in blockstore) but we want this anyway to reduce the computational overhead,
WRT live consensus, in main this only helps with catchup for live syncing nodes, I haven't checked on v0.47.x, but the cpuprofile suggests it may help with active block gossip time as well?
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code commentsThis is an automatic backport of pull request #2964 done by [Mergify](https://mergify.com).