perf(p2p): Remove unnecessary atomic read (backport #2950)#2972
Merged
perf(p2p): Remove unnecessary atomic read (backport #2950)#2972
Conversation
This PR is a driveby change. We were doing an atomic read here, but this is unnecessary. Nothing in the codebase modified this variable after instantiation. Doesn't really feel changelog worthy, but I can add one if we want. Felt like a minor code nit (cherry picked from commit 9ae5886)
melekes
approved these changes
May 2, 2024
czarcas7ic
pushed a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 2, 2024
…ometbft#2972) This PR is a driveby change. We were doing an atomic read here, but this is unnecessary. Nothing in the codebase modified this variable after instantiation. Doesn't really feel changelog worthy, but I can add one if we want. Felt like a minor code nit<hr>This is an automatic backport of pull request cometbft#2950 done by [Mergify](https://mergify.com). Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
czarcas7ic
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 3, 2024
…ometbft#2972) (#41) This PR is a driveby change. We were doing an atomic read here, but this is unnecessary. Nothing in the codebase modified this variable after instantiation. Doesn't really feel changelog worthy, but I can add one if we want. Felt like a minor code nit<hr>This is an automatic backport of pull request cometbft#2950 done by [Mergify](https://mergify.com). Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
mergify bot
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 3, 2024
…ometbft#2972) (#41) This PR is a driveby change. We were doing an atomic read here, but this is unnecessary. Nothing in the codebase modified this variable after instantiation. Doesn't really feel changelog worthy, but I can add one if we want. Felt like a minor code nit<hr>This is an automatic backport of pull request cometbft#2950 done by [Mergify](https://mergify.com). Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> (cherry picked from commit c1cebed)
mergify bot
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 3, 2024
…ometbft#2972) (#41) This PR is a driveby change. We were doing an atomic read here, but this is unnecessary. Nothing in the codebase modified this variable after instantiation. Doesn't really feel changelog worthy, but I can add one if we want. Felt like a minor code nit<hr>This is an automatic backport of pull request cometbft#2950 done by [Mergify](https://mergify.com). Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> (cherry picked from commit c1cebed)
czarcas7ic
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 3, 2024
…ometbft#2972) (#41) (#50) This PR is a driveby change. We were doing an atomic read here, but this is unnecessary. Nothing in the codebase modified this variable after instantiation. Doesn't really feel changelog worthy, but I can add one if we want. Felt like a minor code nit<hr>This is an automatic backport of pull request cometbft#2950 done by [Mergify](https://mergify.com). Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> (cherry picked from commit c1cebed) Co-authored-by: Adam Tucker <adam@osmosis.team>
czarcas7ic
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 3, 2024
…ometbft#2972) (#41) (#51) This PR is a driveby change. We were doing an atomic read here, but this is unnecessary. Nothing in the codebase modified this variable after instantiation. Doesn't really feel changelog worthy, but I can add one if we want. Felt like a minor code nit<hr>This is an automatic backport of pull request cometbft#2950 done by [Mergify](https://mergify.com). Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> (cherry picked from commit c1cebed) Co-authored-by: Adam Tucker <adam@osmosis.team>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a driveby change. We were doing an atomic read here, but this is unnecessary. Nothing in the codebase modified this variable after instantiation.
Doesn't really feel changelog worthy, but I can add one if we want. Felt like a minor code nit
This is an automatic backport of pull request #2950 done by Mergify.