Conversation
0c4c5b3 to
6f204f4
Compare
sergio-mena
approved these changes
Feb 10, 2023
Collaborator
sergio-mena
left a comment
There was a problem hiding this comment.
Thanks Lásaro! In particular for the new, better way of producing the Prometheus plots.
Some of the plots seem to start some time before the experiment. Although I agree it can be interesting to see how the system goes from idle to busy, it adds some noise when comparing them with existing reports (baseline, v0.37.x). The main criterion for PASS or FAIL is how similar new plots are to existing ones.
* Changes to homogeneous results. First version * Tweak to plotting script * Revert "Tweak to plotting script" * Updated homogeneous text and script * Splitting the README.md * Updating the instructions to plotters * Update the latency plotter to print the experiment times in UTC and update the reference to specific experiments in the text * Final plots for homogeneous * Extracted and added baseline data (oct 2022) to the report * Polishing the text * Removed two unsued .png files * Rename homogeneous latencies --------- Co-authored-by: Lasaro <lasaro@informal.systems>
…emoving files not needed. Reorganizing some sections of the report
3385306 to
805143c
Compare
Expand the explantion of the `latency_plotter.py` script
mergify bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
* adding the 2/3 comet 1/3 tm case, without explanations * moving experiment to folder to standardize names * Description of how to run the prometheus plotter file * regenerating figures and deleting the old ones * moving the reporting scripts to this repo * Updating CMT1/3 TM2/3 latency figures * Updating prometheus metrics for cmt1 tm2 case * Updating scripts * extending the window to capture the long tail of experiments * improved plotter, let's you include the average in the graph * Updating prometheus metrics for cmt1 tm2 case * Revert to referencing TM where it makes sense * Updating prometheus metrics for cmt2 tm1 case * Updating prometheus metrics for cmt2 tm1 case and references in the README. * Updating prometheus metrics for cmt1 tm2 case * Fixing section levels. Changed results to table * reducing time window to 20s * reducing time window to 20s * Start splitting the files * reducing time window to 20s in the script * Update the data and comments for homogeneous network (#312) * Changes to homogeneous results. First version * Tweak to plotting script * Revert "Tweak to plotting script" * Updated homogeneous text and script * Splitting the README.md * Updating the instructions to plotters * Update the latency plotter to print the experiment times in UTC and update the reference to specific experiments in the text * Final plots for homogeneous * Extracted and added baseline data (oct 2022) to the report * Polishing the text * Removed two unsued .png files * Rename homogeneous latencies --------- Co-authored-by: Lasaro <lasaro@informal.systems> * making file names consitent with script output and across sections. Removing files not needed. Reorganizing some sections of the report * Plot to the imgs folder. Don't block between plots. * Adding report for half-half configuration. Update scripts include the test. * Fix typo in the `requirements.txt` file. Expand the explantion of the `latency_plotter.py` script * Moving instructions to run to the reporting * Small tweaks in the text --------- Co-authored-by: Sergio Mena <sergio@informal.systems> (cherry picked from commit 2ccf684)
mergify bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
* adding the 2/3 comet 1/3 tm case, without explanations * moving experiment to folder to standardize names * Description of how to run the prometheus plotter file * regenerating figures and deleting the old ones * moving the reporting scripts to this repo * Updating CMT1/3 TM2/3 latency figures * Updating prometheus metrics for cmt1 tm2 case * Updating scripts * extending the window to capture the long tail of experiments * improved plotter, let's you include the average in the graph * Updating prometheus metrics for cmt1 tm2 case * Revert to referencing TM where it makes sense * Updating prometheus metrics for cmt2 tm1 case * Updating prometheus metrics for cmt2 tm1 case and references in the README. * Updating prometheus metrics for cmt1 tm2 case * Fixing section levels. Changed results to table * reducing time window to 20s * reducing time window to 20s * Start splitting the files * reducing time window to 20s in the script * Update the data and comments for homogeneous network (#312) * Changes to homogeneous results. First version * Tweak to plotting script * Revert "Tweak to plotting script" * Updated homogeneous text and script * Splitting the README.md * Updating the instructions to plotters * Update the latency plotter to print the experiment times in UTC and update the reference to specific experiments in the text * Final plots for homogeneous * Extracted and added baseline data (oct 2022) to the report * Polishing the text * Removed two unsued .png files * Rename homogeneous latencies --------- Co-authored-by: Lasaro <lasaro@informal.systems> * making file names consitent with script output and across sections. Removing files not needed. Reorganizing some sections of the report * Plot to the imgs folder. Don't block between plots. * Adding report for half-half configuration. Update scripts include the test. * Fix typo in the `requirements.txt` file. Expand the explantion of the `latency_plotter.py` script * Moving instructions to run to the reporting * Small tweaks in the text --------- Co-authored-by: Sergio Mena <sergio@informal.systems> (cherry picked from commit 2ccf684) # Conflicts: # docs/qa/README.md
lasarojc
added a commit
that referenced
this pull request
Feb 15, 2023
* adding the 2/3 comet 1/3 tm case, without explanations * moving experiment to folder to standardize names * Description of how to run the prometheus plotter file * regenerating figures and deleting the old ones * moving the reporting scripts to this repo * Updating CMT1/3 TM2/3 latency figures * Updating prometheus metrics for cmt1 tm2 case * Updating scripts * extending the window to capture the long tail of experiments * improved plotter, let's you include the average in the graph * Updating prometheus metrics for cmt1 tm2 case * Revert to referencing TM where it makes sense * Updating prometheus metrics for cmt2 tm1 case * Updating prometheus metrics for cmt2 tm1 case and references in the README. * Updating prometheus metrics for cmt1 tm2 case * Fixing section levels. Changed results to table * reducing time window to 20s * reducing time window to 20s * Start splitting the files * reducing time window to 20s in the script * Update the data and comments for homogeneous network (#312) * Changes to homogeneous results. First version * Tweak to plotting script * Revert "Tweak to plotting script" * Updated homogeneous text and script * Splitting the README.md * Updating the instructions to plotters * Update the latency plotter to print the experiment times in UTC and update the reference to specific experiments in the text * Final plots for homogeneous * Extracted and added baseline data (oct 2022) to the report * Polishing the text * Removed two unsued .png files * Rename homogeneous latencies --------- Co-authored-by: Lasaro <lasaro@informal.systems> * making file names consitent with script output and across sections. Removing files not needed. Reorganizing some sections of the report * Plot to the imgs folder. Don't block between plots. * Adding report for half-half configuration. Update scripts include the test. * Fix typo in the `requirements.txt` file. Expand the explantion of the `latency_plotter.py` script * Moving instructions to run to the reporting * Small tweaks in the text --------- Co-authored-by: Sergio Mena <sergio@informal.systems> (cherry picked from commit 2ccf684) Co-authored-by: Lasaro <lasaro@informal.systems>
lasarojc
added a commit
that referenced
this pull request
Feb 15, 2023
* adding the 2/3 comet 1/3 tm case, without explanations * moving experiment to folder to standardize names * Description of how to run the prometheus plotter file * regenerating figures and deleting the old ones * moving the reporting scripts to this repo * Updating CMT1/3 TM2/3 latency figures * Updating prometheus metrics for cmt1 tm2 case * Updating scripts * extending the window to capture the long tail of experiments * improved plotter, let's you include the average in the graph * Updating prometheus metrics for cmt1 tm2 case * Revert to referencing TM where it makes sense * Updating prometheus metrics for cmt2 tm1 case * Updating prometheus metrics for cmt2 tm1 case and references in the README. * Updating prometheus metrics for cmt1 tm2 case * Fixing section levels. Changed results to table * reducing time window to 20s * reducing time window to 20s * Start splitting the files * reducing time window to 20s in the script * Update the data and comments for homogeneous network (#312) * Changes to homogeneous results. First version * Tweak to plotting script * Revert "Tweak to plotting script" * Updated homogeneous text and script * Splitting the README.md * Updating the instructions to plotters * Update the latency plotter to print the experiment times in UTC and update the reference to specific experiments in the text * Final plots for homogeneous * Extracted and added baseline data (oct 2022) to the report * Polishing the text * Removed two unsued .png files * Rename homogeneous latencies --------- Co-authored-by: Lasaro <lasaro@informal.systems> * making file names consitent with script output and across sections. Removing files not needed. Reorganizing some sections of the report * Plot to the imgs folder. Don't block between plots. * Adding report for half-half configuration. Update scripts include the test. * Fix typo in the `requirements.txt` file. Expand the explantion of the `latency_plotter.py` script * Moving instructions to run to the reporting * Small tweaks in the text --------- Co-authored-by: Sergio Mena <sergio@informal.systems> (cherry picked from commit 2ccf684) # Conflicts: # docs/qa/README.md Co-authored-by: Lasaro <lasaro@informal.systems>
8 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #283