refactor(p2p/connection): Slight refactor to sendManyPackets that helps highlight performance improvements#2953
Merged
melekes merged 3 commits intocometbft:mainfrom May 2, 2024
Conversation
and includes my notes
This was referenced Apr 30, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2024
…ps highlight performance improvements (#2953) Fully compatible refactor to the `sendSomePacketMsgs` loop, that I think makes it easier to: 1) Understand the code 2) See how we improve it for serial time performance 3) Puts my notes for how to improve some consensus gossip bottlenecks. --- #### PR checklist - [x] Tests written/updated - N/A, this is fully compatible so no new test updates needed - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - I dont think refactors get changelogs? - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit 622c233)
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2024
…ps highlight performance improvements (#2953) Fully compatible refactor to the `sendSomePacketMsgs` loop, that I think makes it easier to: 1) Understand the code 2) See how we improve it for serial time performance 3) Puts my notes for how to improve some consensus gossip bottlenecks. --- #### PR checklist - [x] Tests written/updated - N/A, this is fully compatible so no new test updates needed - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - I dont think refactors get changelogs? - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit 622c233)
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2024
…ps highlight performance improvements (#2953) Fully compatible refactor to the `sendSomePacketMsgs` loop, that I think makes it easier to: 1) Understand the code 2) See how we improve it for serial time performance 3) Puts my notes for how to improve some consensus gossip bottlenecks. --- #### PR checklist - [x] Tests written/updated - N/A, this is fully compatible so no new test updates needed - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - I dont think refactors get changelogs? - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit 622c233)
This was referenced May 2, 2024
melekes
added a commit
that referenced
this pull request
May 2, 2024
…ps highlight performance improvements (backport #2953) (#2978) Fully compatible refactor to the `sendSomePacketMsgs` loop, that I think makes it easier to: 1) Understand the code 2) See how we improve it for serial time performance 3) Puts my notes for how to improve some consensus gossip bottlenecks. --- #### PR checklist - [x] Tests written/updated - N/A, this is fully compatible so no new test updates needed - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - I dont think refactors get changelogs? - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2953 done by [Mergify](https://mergify.com). Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
melekes
added a commit
that referenced
this pull request
May 2, 2024
…ps highlight performance improvements (backport #2953) (#2977) Fully compatible refactor to the `sendSomePacketMsgs` loop, that I think makes it easier to: 1) Understand the code 2) See how we improve it for serial time performance 3) Puts my notes for how to improve some consensus gossip bottlenecks. --- #### PR checklist - [x] Tests written/updated - N/A, this is fully compatible so no new test updates needed - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - I dont think refactors get changelogs? - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2953 done by [Mergify](https://mergify.com). Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
melekes
added a commit
that referenced
this pull request
May 2, 2024
…ps highlight performance improvements (backport #2953) (#2976) Fully compatible refactor to the `sendSomePacketMsgs` loop, that I think makes it easier to: 1) Understand the code 2) See how we improve it for serial time performance 3) Puts my notes for how to improve some consensus gossip bottlenecks. --- #### PR checklist - [x] Tests written/updated - N/A, this is fully compatible so no new test updates needed - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - I dont think refactors get changelogs? - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2953 done by [Mergify](https://mergify.com). Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
ValarDragon
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 4, 2024
…ps highlight performance improvements (backport cometbft#2953) (cometbft#2978) Fully compatible refactor to the `sendSomePacketMsgs` loop, that I think makes it easier to: 1) Understand the code 2) See how we improve it for serial time performance 3) Puts my notes for how to improve some consensus gossip bottlenecks. --- #### PR checklist - [x] Tests written/updated - N/A, this is fully compatible so no new test updates needed - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - I dont think refactors get changelogs? - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request cometbft#2953 done by [Mergify](https://mergify.com). Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
ValarDragon
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 7, 2024
…ps highlight performance improvements (backport cometbft#2953) (cometbft#2978) Fully compatible refactor to the `sendSomePacketMsgs` loop, that I think makes it easier to: 1) Understand the code 2) See how we improve it for serial time performance 3) Puts my notes for how to improve some consensus gossip bottlenecks. --- #### PR checklist - [x] Tests written/updated - N/A, this is fully compatible so no new test updates needed - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - I dont think refactors get changelogs? - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request cometbft#2953 done by [Mergify](https://mergify.com). Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
7 tasks
PaddyMc
pushed a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 22, 2024
…ps highlight performance improvements (backport cometbft#2953) (cometbft#2978) (#61) * refactor(p2p/connection): Slight refactor to sendManyPackets that helps highlight performance improvements (cometbft#2978) (#61) Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
mergify bot
pushed a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 22, 2024
…ps highlight performance improvements (backport cometbft#2953) (cometbft#2978) (#61) * refactor(p2p/connection): Slight refactor to sendManyPackets that helps highlight performance improvements (cometbft#2978) (#61) Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> (cherry picked from commit 6d0070e)
7 tasks
PaddyMc
pushed a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 23, 2024
…ps highlight performance improvements (backport cometbft#2953) (cometbft#2978) (#61) (#65) * refactor(p2p/connection): Slight refactor to sendManyPackets that helps highlight performance improvements (cometbft#2978) (#61) Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> (cherry picked from commit 6d0070e) Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully compatible refactor to the
sendSomePacketMsgsloop, that I think makes it easier to:PR checklist
.changelog(we use unclog to manage our changelog) - I dont think refactors get changelogs?docs/orspec/) and code comments