spec(abci): slight improvements to ABCI spec (@angrav's feedback from Anoma)#2929
Merged
sergio-mena merged 3 commits intomainfrom Apr 30, 2024
Merged
spec(abci): slight improvements to ABCI spec (@angrav's feedback from Anoma)#2929sergio-mena merged 3 commits intomainfrom
sergio-mena merged 3 commits intomainfrom
Conversation
f04771b to
2e78a2e
Compare
andynog
approved these changes
Apr 29, 2024
Collaborator
andynog
left a comment
There was a problem hiding this comment.
lgtm, just minor typo fixes suggestions
Co-authored-by: Andy Nogueira <me@andynogueira.dev>
mergify bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
… Anoma) (#2929) --- #### PR checklist - [ ] ~~Tests written/updated~~ - [ ] ~~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~~ - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> (cherry picked from commit 02f2528)
Merged
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
… Anoma) (#2929) --- #### PR checklist - [ ] ~~Tests written/updated~~ - [ ] ~~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~~ - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> (cherry picked from commit 02f2528) # Conflicts: # spec/abci/abci++_methods.md
Merged
4 tasks
sergio-mena
added a commit
that referenced
this pull request
Apr 30, 2024
… Anoma) (backport #2929) (#2940) --- #### PR checklist - [ ] ~~Tests written/updated~~ - [ ] ~~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~~ - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2929 done by [Mergify](https://mergify.com). Co-authored-by: Sergio Mena <sergio@informal.systems>
sergio-mena
added a commit
that referenced
this pull request
Apr 30, 2024
sergio-mena
added a commit
that referenced
this pull request
Apr 30, 2024
… Anoma) (#2929) --- - [ ] ~~Tests written/updated~~ - [ ] ~~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~~ - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev>
sergio-mena
added a commit
that referenced
this pull request
Apr 30, 2024
… Anoma) (backport #2929) (#2941) --- #### PR checklist - [ ] ~~Tests written/updated~~ - [ ] ~~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~~ - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2929 done by [Mergify](https://mergify.com). --------- Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Andy Nogueira <me@andynogueira.dev>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Tests written/updatedChangelog entry added in.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments