Merged
Conversation
…into jasmina/0.34-qa-tm2cmt1
…into jasmina/0.34-qa-tm2cmt1
sergio-mena
reviewed
Feb 10, 2023
| **Result: PASS** | ||
|
|
||
| Date: 2023-02-08 | ||
|
|
Collaborator
There was a problem hiding this comment.
Please change "version" to "versions", and add
CometBFT: 3b78343 (if that's the one you used)
Tendermint Core: [add here the hash of the Tendermint Core version you used]
sergio-mena
approved these changes
Feb 10, 2023
Collaborator
sergio-mena
left a comment
There was a problem hiding this comment.
Thanks! Looking excellent!
mergify bot
pushed a commit
that referenced
this pull request
Feb 10, 2023
* Report Skeleton * Added results on 2/3TM and 1/3CMT * Added img files * Cropped pics * First batch of results * Fixed image offsets * All metrics in * Added average plots, merged with Sergios branch * Added todo * Updated graphs * scaling img * scaling img * Added versions --------- Co-authored-by: Sergio Mena <sergio@informal.systems> (cherry picked from commit f6e70af)
mergify bot
pushed a commit
that referenced
this pull request
Feb 10, 2023
* Report Skeleton * Added results on 2/3TM and 1/3CMT * Added img files * Cropped pics * First batch of results * Fixed image offsets * All metrics in * Added average plots, merged with Sergios branch * Added todo * Updated graphs * scaling img * scaling img * Added versions --------- Co-authored-by: Sergio Mena <sergio@informal.systems> (cherry picked from commit f6e70af)
sergio-mena
pushed a commit
that referenced
this pull request
Feb 10, 2023
* Report Skeleton * Added results on 2/3TM and 1/3CMT * Added img files * Cropped pics * First batch of results * Fixed image offsets * All metrics in * Added average plots, merged with Sergios branch * Added todo * Updated graphs * scaling img * scaling img * Added versions --------- Co-authored-by: Sergio Mena <sergio@informal.systems> (cherry picked from commit f6e70af) Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
sergio-mena
pushed a commit
that referenced
this pull request
Feb 10, 2023
* Report Skeleton * Added results on 2/3TM and 1/3CMT * Added img files * Cropped pics * First batch of results * Fixed image offsets * All metrics in * Added average plots, merged with Sergios branch * Added todo * Updated graphs * scaling img * scaling img * Added versions --------- Co-authored-by: Sergio Mena <sergio@informal.systems> (cherry picked from commit f6e70af) Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #283.