chore: mark state and store packages as deprecated#2822
Merged
Conversation
note I didn't use `Deprecated` keyword because doing this would result in a lot of warnings for us & our users.
adizere
approved these changes
Apr 16, 2024
Contributor
adizere
left a comment
There was a problem hiding this comment.
Looks good, guess it makes sense to avoid using the magic key word.
cason
approved these changes
Apr 16, 2024
cason
left a comment
There was a problem hiding this comment.
Thank you for this.
I don't understand the usage of // XXX: in terms of comment, but if you find it more appropriate, good.
Co-authored-by: Daniel <daniel.cason@informal.systems>
mergify bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
Please note that I didn't use the `Deprecated` keyword because doing this would result in many warnings for us and our users. Follow-up to #2709 --- #### PR checklist - [ ] ~~Tests written/updated~~ - [ ] ~~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~~ - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: Daniel <daniel.cason@informal.systems> (cherry picked from commit 627b6e7)
4 tasks
melekes
added a commit
that referenced
this pull request
Apr 17, 2024
…2828) Please note that I didn't use the `Deprecated` keyword because doing this would result in many warnings for us and our users. Follow-up to #2709 --- #### PR checklist - [ ] ~~Tests written/updated~~ - [ ] ~~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~~ - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2822 done by [Mergify](https://mergify.com). Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note that I didn't use the
Deprecatedkeyword because doing this would result in many warnings for us and our users.Follow-up to #2709
PR checklist
Tests written/updatedChangelog entry added in.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments