Conversation
lasarojc
reviewed
Feb 8, 2023
cason
reviewed
Feb 8, 2023
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
lasarojc
approved these changes
Feb 20, 2023
Contributor
lasarojc
left a comment
There was a problem hiding this comment.
The removal of v1 and renaming of v0 looks good to me
sergio-mena
approved these changes
Feb 21, 2023
Collaborator
sergio-mena
left a comment
There was a problem hiding this comment.
Thanks @hvanz for this!
3 tasks
lukasz-zimnoch
added a commit
to mezo-org/mezod
that referenced
this pull request
Aug 6, 2024
CometBFT removed the mempool version field from `config.toml`. See: cometbft/cometbft#281
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #260
Note to reviewers: moving the files from
mempool/v0tomempoolcreates a dependency cyclemempool/clist_mempool_test.go -> internal/test/block.go -> state -> mempool. That's why I moved the functionmakeBlocksfrominternal/test/block.gotoconsensus/replay_test.go(the only place where it is used). The functionMakeVoteSetininternal/test/commit.gowas also creating a cycle, and it was unused, so I removed it.Tasks
mempool/v1.Versionfield fromMempoolConfig.sender,priority,mempool_error) ofResponseCheckTx, which are related to the priority mempool.mempool/v0/*tomempool/.