docs(qa/v1): Report on saturation point and 200-nodes test#2667
Merged
Conversation
|
We need to find a way to render the y axis of the graphs similar. |
adizere
reviewed
Apr 4, 2024
adizere
reviewed
Apr 4, 2024
Contributor
adizere
left a comment
There was a problem hiding this comment.
The results are very insightful, great work Hernan!
I left a few questions that were sparked from traversing main doc.
docs/references/qa/CometBFT-QA-v1.md
Outdated
| In both cases, most latencies are around or below 4 seconds. On `v0.38` there are peaks reaching 10 | ||
| seconds, while on `v1` (without LE) the only peak reaches 8 seconds. In general, the images are | ||
| similar. From this small experiment we infer that the latencies measured on `v1` are not worse than | ||
| those of the baseline. With latency emulation, the latencies are considerably higher, as expected. |
Contributor
There was a problem hiding this comment.
I guess indeed, with latency emulation, the system is trading latency for throughput.
cason
approved these changes
Apr 5, 2024
| performance for `v1` compared to `v1` without latency emulation, althugh not by an order of | ||
| magnitude. Moving forward with the next QA tests, it may be prudent to consider adjusting the | ||
| saturation point to a slightly lower value. Determining this adjustment will require conducting new | ||
| experiments on the network with latency emulation. |
There was a problem hiding this comment.
Also consider adapting the timeout values.
sergio-mena
reviewed
Apr 9, 2024
sergio-mena
reviewed
Apr 9, 2024
sergio-mena
reviewed
Apr 9, 2024
Co-authored-by: Sergio Mena <sergio@informal.systems>
sergio-mena
reviewed
Apr 9, 2024
sergio-mena
reviewed
Apr 9, 2024
Co-authored-by: Sergio Mena <sergio@informal.systems>
sergio-mena
reviewed
Apr 9, 2024
sergio-mena
reviewed
Apr 9, 2024
sergio-mena
reviewed
Apr 9, 2024
sergio-mena
reviewed
Apr 9, 2024
sergio-mena
reviewed
Apr 9, 2024
sergio-mena
reviewed
Apr 9, 2024
sergio-mena
reviewed
Apr 9, 2024
sergio-mena
reviewed
Apr 9, 2024
sergio-mena
reviewed
Apr 9, 2024
cason
reviewed
Apr 9, 2024
cason
reviewed
Apr 9, 2024
Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Daniel <daniel.cason@informal.systems>
mergify bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
Closes #2461, #2513 This report includes results for tests with and without latency emulation. [Rendered](https://github.com/cometbft/cometbft/blob/hvanz/qa-v1-report-2461/docs/references/qa/CometBFT-QA-v1.md) --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [X] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Daniel <daniel.cason@informal.systems> Co-authored-by: Sergio Mena <sergio@informal.systems> (cherry picked from commit 53e6127) # Conflicts: # scripts/qa/reporting/prometheus_plotter.py
4 tasks
hvanz
added a commit
that referenced
this pull request
Apr 12, 2024
…2667) (#2764) Closes #2461, #2513 This report includes results for tests with and without latency emulation. [Rendered](https://github.com/cometbft/cometbft/blob/hvanz/qa-v1-report-2461/docs/references/qa/CometBFT-QA-v1.md) --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [X] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2667 done by [Mergify](https://mergify.com). --------- Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com> Co-authored-by: hvanz <hernan.vanzetto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2461, #2513
This report includes results for tests with and without latency emulation.
Rendered
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments