p2p: add a per-message type send and receive metric (backport #9622)#230
Merged
jmalicevic merged 39 commits intov0.37.xfrom Jan 31, 2023
Merged
p2p: add a per-message type send and receive metric (backport #9622)#230jmalicevic merged 39 commits intov0.37.xfrom
jmalicevic merged 39 commits intov0.37.xfrom
Conversation
* p2p: ressurrect the p2p envelope and use to calculate message metric Co-authored-by: Callum Waters <cmwaters19@gmail.com> (cherry picked from commit 09b8708) # Conflicts: # cmd/tendermint/commands/rollback.go # go.mod # go.sum # p2p/peer.go # p2p/peer_set_test.go
7 tasks
Collaborator
Author
|
I would add a changelog entry for this change, seems like a not so minor change to developers. |
Contributor
Agreed! I'd say the major change here is the replacement of the |
thanethomson
approved these changes
Jan 31, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of tendermint/tendermint#9622. Original PR tendermint/tendermint#9640 .
Addresses #219 .