p2p: add a per-message type send and receive metric (backport #9622)#9640
p2p: add a per-message type send and receive metric (backport #9622)#9640mergify[bot] wants to merge 31 commits intov0.37.xfrom
Conversation
* p2p: ressurrect the p2p envelope and use to calculate message metric Co-authored-by: Callum Waters <cmwaters19@gmail.com> (cherry picked from commit 09b8708) # Conflicts: # cmd/tendermint/commands/rollback.go # go.mod # go.sum # p2p/peer.go # p2p/peer_set_test.go
f432562 to
cc9e8f4
Compare
|
Will we be rolling this out with v0.37.0? If not, and if we roll it out with v0.37.1, please ensure there are no breaking changes between those two versions. cc @sergio-mena |
I was planning to just port the changes made to keep v0.34 from breaking onto this branch. Should be straightforward enough and doesn't change our release process. |
c5e641b to
93c8c1f
Compare
|
I am 50-50 on this. I know having coherent metrics in At the very least, I agree with @thanethomson this should only be merged after the first release in |
|
Sure thing @sergio-mena - perhaps it makes sense to defer merging this to v0.37.1. I've already added the |
This is an automatic backport of pull request #9622 done by Mergify.
Cherry-pick of 09b8708 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com