Closed
Conversation
…increases the test's timeout to 30s
…t/add-patches-to-master
…o faddat/add-patches-to-master
transport multiplex
3 tasks
Collaborator
|
|
Contributor
Author
|
Working on it sir :D |
3 tasks
… even be a halt vector. So, I propose like: * for now we bump the timeout to 35s, but we shouldn't go higher * we open an issue to see if we can make evidence submission faster
Contributor
Author
|
This branch is no longer mergeable and I should break it into individual changes. |
4 tasks
4 tasks
This was referenced Jan 26, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
This PR addresses test reliability issues in testreader and testwriter. From: #1954 --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [ ] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
mergify bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
This PR addresses test reliability issues in testreader and testwriter. From: #1954 --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [ ] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> (cherry picked from commit 075d3b5) # Conflicts: # internal/flowrate/io_test.go
melekes
added a commit
that referenced
this pull request
Feb 8, 2024
This PR addresses test reliability issues in testreader and testwriter. From: #1954 --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [ ] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
This was referenced Feb 10, 2024
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 12, 2024
This PR should resolve the odd case where a group of rpc tests fail simultaneously. from: #1954 --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [ ] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
mergify bot
pushed a commit
that referenced
this pull request
Feb 12, 2024
This PR should resolve the odd case where a group of rpc tests fail simultaneously. from: #1954 --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [ ] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit 630a94b) # Conflicts: # rpc/jsonrpc/server/http_server_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
@melekes - I'd like to merge this branch, and then open another torture branch and run the tests a few thousand times. But I think we are in good shape.
NOTES FOR REVIEWERS
Some of the fixes here involved small changes to the tolerances of tests in situations where the code may behave in a slightly variable way without malfunctioning. I bet that is the key item for review.
This needs to be broken into pieces.
I consider this branch to be mergable now, and I suppose what I'll do is make another one where the other tests I identified as having issues are run 100 times. That was totally key to fixingTestTransportMultiplexAcceptNonBlockingbecause it got me the data I needed to understand the problem.PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments