Skip to content

run tests 40x against the unmodified master branch#1950

Closed
faddat wants to merge 2 commits intocometbft:mainfrom
faddat:patch-3
Closed

run tests 40x against the unmodified master branch#1950
faddat wants to merge 2 commits intocometbft:mainfrom
faddat:patch-3

Conversation

@faddat
Copy link
Contributor

@faddat faddat commented Jan 2, 2024

My original "run the linter against the code" PR contained many, many changes from a linting session. So, as with the others, please do not merge this.

It's being used to find and fix flaky tests.

Probably we don't want to merge this, though it might be interesting as a temporary measure till we have gotten all of the tests (or underlying code) tuned right)


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@faddat faddat requested a review from a team as a code owner January 2, 2024 19:16
@faddat faddat requested a review from a team January 2, 2024 19:16
@faddat faddat mentioned this pull request Jan 2, 2024
@melekes
Copy link
Collaborator

melekes commented Jan 3, 2024

Closing in favor of #1954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants