Skip to content

Run comet tests on v0.38.x 40x#1940

Closed
faddat wants to merge 2 commits intocometbft:v0.38.xfrom
faddat:patch-2
Closed

Run comet tests on v0.38.x 40x#1940
faddat wants to merge 2 commits intocometbft:v0.38.xfrom
faddat:patch-2

Conversation

@faddat
Copy link
Contributor

@faddat faddat commented Jan 2, 2024

This PR will run the comet tests on v0.38.x 40 times.

Note: this PR contains no personal attacks but may reveal bugs. Please do not merge it it is for testing only.


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@faddat faddat requested a review from a team as a code owner January 2, 2024 17:46
@faddat faddat changed the title Run comet tests on v0.38.x, which is in production, 40x Run comet tests on v0.38.x 40x Jan 2, 2024
@faddat faddat marked this pull request as draft January 2, 2024 17:52
@faddat faddat mentioned this pull request Jan 2, 2024
24 tasks
@melekes
Copy link
Collaborator

melekes commented Jan 8, 2024

We've got what we wanted, so closing.

@melekes melekes closed this Jan 8, 2024
itsdevbear pushed a commit to berachain/polaris that referenced this pull request Jan 17, 2024
In my view the berachain testnet experienced unreliability due to
upstream issues in Comet.

* cometbft/cometbft#1940

While I cannot be sure, I think that some of the results that I got in
recent benchmarks of goleveldb actually represent clear bugs that could
under certain circumstances be used to halt chains.

* cometbft/cometbft-db#115

So here's the thinking:

1) drop goleveldb for pebble by literally specifying pebble statically
in the code
2) reduce max_bytes to 1mb
3) increase the size of the validator set and distribute VP evenly
4) torture the network, including torturing RPCs

Co-authored-by: Devon Bear <itsdevbear@berachain.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants