Merged
Conversation
caaa3b7 to
7df5a97
Compare
mzabaluev
reviewed
Nov 30, 2023
lasarojc
reviewed
Nov 30, 2023
lasarojc
reviewed
Nov 30, 2023
lasarojc
reviewed
Nov 30, 2023
lasarojc
reviewed
Nov 30, 2023
lasarojc
reviewed
Nov 30, 2023
lasarojc
reviewed
Nov 30, 2023
lasarojc
reviewed
Nov 30, 2023
lasarojc
reviewed
Nov 30, 2023
lasarojc
reviewed
Nov 30, 2023
lasarojc
reviewed
Nov 30, 2023
lasarojc
approved these changes
Nov 30, 2023
Contributor
lasarojc
left a comment
There was a problem hiding this comment.
Minor suggestions. LGTM otherwise.
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
…lines Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
774fb86 to
8f7f516
Compare
thanethomson
added a commit
that referenced
this pull request
Nov 30, 2023
Remove unreleased entries because they will land in the `v1.0.0-alpha.1` release in #1710 and will then be ported to `main` in a subsequent PR. Signed-off-by: Thane Thomson <connect@thanethomson.com>
3 tasks
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
* ci: Add nightly E2E workflow for v1.x branch Signed-off-by: Thane Thomson <connect@thanethomson.com> * ci: Enable weekly Dependabot updates for v1.x branch Signed-off-by: Thane Thomson <connect@thanethomson.com> * changelog: Remove unreleased entries Remove unreleased entries because they will land in the `v1.0.0-alpha.1` release in #1710 and will then be ported to `main` in a subsequent PR. Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
…g v0.7.0) Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
adizere
approved these changes
Dec 4, 2023
Contributor
adizere
left a comment
There was a problem hiding this comment.
So many good things in here, go team! 🥇
4 tasks
sergio-mena
added a commit
that referenced
this pull request
Mar 18, 2024
Changes in preparation for our second alpha release of `v1.0.0`: - [CHANGELOG rendered](https://github.com/cometbft/cometbft/blob/release/v1.0.0-alpha.2/CHANGELOG.md) - [Manual E2E run](https://github.com/cometbft/cometbft/actions/runs/8283569894) IMPORTANT: The first commit of this PR is manually undoing the `unclog release` that was performed for `v1.0.0-alpha.1` (#1710). In our release process, pre-releases do not have their own section in the changelog, so we must _not_ run `unclog release` when cutting pre-releases (see `RELEASES.md`). Therefore, it is advised to exclude the first commit from the diff view when reviewing this PR. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [ ] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: hvanz <hernan.vanzetto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key updated documentation rendered:
Requests to reviewers:
release/v1.0.0-alpha.1).✅ Manual run of the E2E nightlies: https://github.com/cometbft/cometbft/actions/runs/7064400936
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments