e2e v0.38-experimental :Fix RPC port reference#1503
Merged
jmalicevic merged 3 commits intov0.38.x-experimentalfrom Oct 25, 2023
Merged
e2e v0.38-experimental :Fix RPC port reference#1503jmalicevic merged 3 commits intov0.38.x-experimentalfrom
jmalicevic merged 3 commits intov0.38.x-experimentalfrom
Conversation
cason
reviewed
Oct 16, 2023
| ports: | ||
| - 26656 | ||
| - {{ if .ProxyPort }}{{ .ProxyPort }}:{{ end }}26657 | ||
| - {{ if .RPCProxyPort }}{{ .RPCProxyPort }}:{{ end }}26657 |
There was a problem hiding this comment.
Should we also add the other ports, present from line 80 to 85?
There was a problem hiding this comment.
@hvanz pointed out the inconsistency of these two fields in another PR.
17 tasks
lasarojc
pushed a commit
that referenced
this pull request
Nov 13, 2023
* Fix RPC port reference * Fixed docker port alias (#1507) * Undo line change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #1507
We started working on the fix on this branch but realized it was broken in main as well. Thus it was merged to main with #1507 and the commit cherry picked after that.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments