grpc: Add base gRPC server with version service to v0.38.x-experimental#1437
Merged
jmalicevic merged 9 commits intov0.38.x-experimentalfrom Oct 10, 2023
Merged
Conversation
* proto: Add VersionService Signed-off-by: Thane Thomson <connect@thanethomson.com> * proto: make proto-gen Signed-off-by: Thane Thomson <connect@thanethomson.com> * config: Add gRPC server section Signed-off-by: Thane Thomson <connect@thanethomson.com> * rpc/grpc: Add server with support for version service Signed-off-by: Thane Thomson <connect@thanethomson.com> * node: Add gRPC server Signed-off-by: Thane Thomson <connect@thanethomson.com> * rpc/grpc: Add client with support for version service Signed-off-by: Thane Thomson <connect@thanethomson.com> * test/e2e: Add gRPC server test of version service Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add changelog entries Signed-off-by: Thane Thomson <connect@thanethomson.com> * rpc: Fix test broken by introduction of gRPC service Some of the RPC tests run Comet nodes in goroutines, causing port conflicts. This randomizes the port assigned to the gRPC server, reducing the likelihood of port conflicts. Signed-off-by: Thane Thomson <connect@thanethomson.com> * rpc/grpc: Update log message format to conform to RPC log style Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com>
3 tasks
3 tasks
3 tasks
5 tasks
hvanz
reviewed
Oct 10, 2023
hvanz
reviewed
Oct 10, 2023
cason
commented
Oct 10, 2023
3 tasks
lasarojc
pushed a commit
that referenced
this pull request
Nov 13, 2023
…al (#1437) * grpc: Add base gRPC server with version service (#818) * proto: Add VersionService Signed-off-by: Thane Thomson <connect@thanethomson.com> * proto: make proto-gen Signed-off-by: Thane Thomson <connect@thanethomson.com> * config: Add gRPC server section Signed-off-by: Thane Thomson <connect@thanethomson.com> * rpc/grpc: Add server with support for version service Signed-off-by: Thane Thomson <connect@thanethomson.com> * node: Add gRPC server Signed-off-by: Thane Thomson <connect@thanethomson.com> * rpc/grpc: Add client with support for version service Signed-off-by: Thane Thomson <connect@thanethomson.com> * test/e2e: Add gRPC server test of version service Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add changelog entries Signed-off-by: Thane Thomson <connect@thanethomson.com> * rpc: Fix test broken by introduction of gRPC service Some of the RPC tests run Comet nodes in goroutines, causing port conflicts. This randomizes the port assigned to the gRPC server, reducing the likelihood of port conflicts. Signed-off-by: Thane Thomson <connect@thanethomson.com> * rpc/grpc: Update log message format to conform to RPC log style Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> * Resolved cherry pick conflicts * grpcs: adding legacy gRPC to e2e test suite * grpc: added legacy gRPC ping test to e2e test suite * grpc: fix lint check, used of deprecated method * Added clarification in config * grpc: fixing backport issued spotted by @hvanz * grpc: replacing port for legacy gRPC endpoint * grpc: removing setting not present on main/v0.38.x --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1421.
Manual backport of #818, which introduces a new base gRPC service. The new gRPC service is implemented under
rpc/grpc/clientandrpc/grpc/server. The destination branch contains a minimal, legacy gRPC implementation that has been deprecated. It is implemented underrpc/grpcand is preserved by this PR.So, this PR introduces a new base gRPC service that is supposed to co-exist with the existing/legacy gRPC service. The unit tests for the legacy gRPC service were configured to have also the new gRPC service enabled. The e2e test suite was updated to enable the legacy gRPC service, in addition to the new base gRPC service. These changes are intended to attest that both gRPC service implementation can properly co-exist.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments