Replace tm-db with cometbft-db on main#137
Merged
thanethomson merged 16 commits intomainfrom Jan 19, 2023
Merged
Conversation
main
8ab2565 to
625c509
Compare
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
…uilding of database support Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
134034e to
c0b5511
Compare
3 tasks
sergio-mena
approved these changes
Jan 19, 2023
consensus/reactor_test.go
Outdated
| Round: 1, Index: 1, Type: cmtproto.PrevoteType}, | ||
| Message: &cmtcons.HasVote{ | ||
| Height: 1, | ||
| Round: 1, Index: 1, Type: cmtproto.PrevoteType, |
Collaborator
There was a problem hiding this comment.
[minor] Might want to separate each field in its own line
Contributor
Author
There was a problem hiding this comment.
It's weird the formatter didn't pick this up. I suspect that eventually switching to something like gofumpt for formatting will help here, but we need to resolve some of our concerns around its use first.
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Contributor
|
For me it worked only after i used |
3 tasks
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 20, 2023
Follow-up to #137. Fixes the Docker builds that were failing to be parsed by GitHub Actions. Also fixes our `make build-docker` target to build images in the same way we do in CI. On Linux, I have to explicitly tell Docker to use BuildKit to pass the target/build platform args in: ```bash DOCKER_BUILDKIT=1 make build-docker ``` Given that I've also proven now that the images do build in CI (see [this workflow](https://github.com/cometbft/cometbft/actions/runs/3964436268/jobs/6793294390) and [this one](https://github.com/cometbft/cometbft/actions/runs/3964436273/jobs/6793294238)), we no longer need to build on every change to every pull request. The E2E node Docker image in particular takes nearly 30mins to build, so that would slow us down tremendously. It's far better to build those images only once PRs get merged. --- #### PR checklist - [x] Tests written/updated, or no tests needed - [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed - [x] Updated relevant documentation (`docs/`) and code comments, or no documentation updates needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133.
This needs to temporarily update all of our workflows and Docker image builds to ensure that they can reach the cometbft-db repository. I've logged an issue to keep track of reverting this in #158.
I'm currently manually running our nightly E2E tests on this branch to ensure that this still works: https://github.com/cometbft/cometbft/actions/runs/3952269253
This will have to be manually backported to
v0.37.xandv0.34.x.After this change, while the repos are still private, to be able to build the Docker images and run the E2E tests locally you'll need to do the following for each shell in which you're working:
Your GitHub API token must have full access (read/write) to all repositories (i.e. the repo checkbox when configuring permissions). See https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token
I'd recommend setting an expiry of 30 days to any tokens used for this purpose, so we don't accidentally leave them lingering.
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed