Merged
Conversation
Collaborator
|
The following two entries could be combined into one:
|
Collaborator
Author
I agree with you, but this is from |
jmalicevic
approved these changes
Sep 12, 2023
thanethomson
approved these changes
Sep 12, 2023
Contributor
thanethomson
left a comment
There was a problem hiding this comment.
Nice! Just 1 minor spelling nit, but otherwise LGTM!
.changelog/v0.38.0/summary.md
Outdated
|
|
||
| This release includes the second part of ABCI++, called ABCI 2.0. | ||
| ABCI 2.0 introduces ABCI methods `ExtendVote` and `VerifyVoteExtension`. | ||
| These new metthods allow the application to add data (opaque to CometBFT), |
Contributor
There was a problem hiding this comment.
Suggested change
| These new metthods allow the application to add data (opaque to CometBFT), | |
| These new methods allow the application to add data (opaque to CometBFT), |
Applying this change will require rebuilding the changelog with unclog.
sergio-mena
added a commit
that referenced
this pull request
Sep 12, 2023
* Prepare changelog for release * Prepare `UPGRADING.md` * Bump version * Fix date format * Remove duplicate changelog entries * Formatted #890 in changelog * Add log entry in breaking changes for RPC block events * Fix typo
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
…38.0` (#1341) * [cherry-pick] Release v0.38.0 (#1337) * Prepare changelog for release * Prepare `UPGRADING.md` * Bump version * Fix date format * Remove duplicate changelog entries * Formatted #890 in changelog * Add log entry in breaking changes for RPC block events * Fix typo * Fixed `UPGRADING.md`
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered CHANGELOG.md
E2E manual run on this branch: https://github.com/cometbft/cometbft/actions/runs/6158591090
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments