Skip to content

Fix typo: exent -> event#1329

Merged
thanethomson merged 1 commit intocometbft:v0.37.xfrom
p-offtermatt:patch-1
Sep 12, 2023
Merged

Fix typo: exent -> event#1329
thanethomson merged 1 commit intocometbft:v0.37.xfrom
p-offtermatt:patch-1

Conversation

@p-offtermatt
Copy link
Contributor

@p-offtermatt p-offtermatt commented Sep 11, 2023

Closes: #1328

Tiny typo fix.

@p-offtermatt p-offtermatt requested a review from a team as a code owner September 11, 2023 15:22
lasarojc
lasarojc approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@lasarojc lasarojc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thanethomson
Copy link
Contributor

thanethomson commented Sep 11, 2023

To which versions should this be backported?

@p-offtermatt
Copy link
Contributor Author

p-offtermatt commented Sep 12, 2023

I personally care about v0.37.x and v0.34.x.

@thanethomson thanethomson added backport-to-v0.34.x backport-to-v0.38.x Tell Mergify to backport the PR to v0.38.x labels Sep 12, 2023
@thanethomson thanethomson changed the base branch from v0.37.x to main September 12, 2023 10:46
@thanethomson thanethomson requested a review from a team as a code owner September 12, 2023 10:46
@thanethomson thanethomson requested a review from a team September 12, 2023 10:46
@thanethomson thanethomson changed the base branch from main to v0.37.x September 12, 2023 10:46
@thanethomson
Copy link
Contributor

thanethomson commented Sep 12, 2023

@p-offtermatt, our usual process is to submit PRs to main and then backport to the relevant release branches from there. Could you please rebase this PR onto main? We'll make sure it gets into the relevant backport branches.

@p-offtermatt p-offtermatt changed the base branch from v0.37.x to main September 12, 2023 11:11
@p-offtermatt p-offtermatt changed the base branch from main to v0.37.x September 12, 2023 11:11
@p-offtermatt
Copy link
Contributor Author

p-offtermatt commented Sep 12, 2023 •
edited
Loading

Not sure how to do this here because the typo is not present on main https://github.com/cometbft/cometbft/blob/main/state/txindex/indexer_service.go#L102C20-L102C20 - do you have any guidance for this situation?

@thanethomson thanethomson removed backport-to-v0.37.x backport-to-v0.38.x Tell Mergify to backport the PR to v0.38.x labels Sep 12, 2023
@thanethomson
Copy link
Contributor

thanethomson commented Sep 12, 2023

Ah, I see. I suspect we'll need to manually backport this to v0.34.x.

@thanethomson thanethomson merged commit be0df2e into cometbft:v0.37.x Sep 12, 2023
thanethomson pushed a commit that referenced this pull request Sep 12, 2023
@p-offtermatt @thanethomson
Fix typo: exent -> event (#1329)
5c248c0
@thanethomson thanethomson mentioned this pull request Sep 12, 2023
Merged
3 tasks
@p-offtermatt
Copy link
Contributor Author

p-offtermatt commented Sep 13, 2023

Thank you!

sergio-mena added a commit that referenced this pull request Sep 26, 2023
@thanethomson @p-offtermatt
@lasarojc @sergio-mena
Fix typo: exent -> event (#1329) (#1342)
8d4b622 
Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>
Co-authored-by: lasaro <lasaro@informal.systems>
Co-authored-by: Sergio Mena <sergio@informal.systems>
@andynog andynog mentioned this pull request Sep 26, 2023
Closed
@sergio-mena sergio-mena mentioned this pull request Oct 25, 2023
Closed
3 tasks
@thanethomson thanethomson added the spelling PR exclusively related to spelling errors label Dec 12, 2023
@faddat faddat mentioned this pull request Jan 5, 2024
Closed
3 tasks
g3ndo9kar9 pushed a commit to skip-mev/cometbft that referenced this pull request Jan 16, 2024
@p-offtermatt @g3ndo9kar9
Fix typo: exent -> event (cometbft#1329)
8128fbd
This was referenced Feb 25, 2024
Closed
Closed
@faddat faddat mentioned this pull request Mar 20, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@thanethomson thanethomson thanethomson approved these changes

@lasarojc lasarojc lasarojc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

spelling PR exclusively related to spelling errors

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@p-offtermatt @thanethomson @lasarojc