Skip to content

Renaming in docker-related files#110

Merged
sergio-mena merged 4 commits intomainfrom
sergio/103-update-test-infra
Jan 16, 2023
Merged

Renaming in docker-related files#110
sergio-mena merged 4 commits intomainfrom
sergio/103-update-test-infra

Conversation

@sergio-mena
Copy link
Collaborator

@sergio-mena sergio-mena commented Jan 13, 2023 •
edited
Loading

Contributes to #103

Criterion for selecting the occurrences of T*** to replace:

$ find . -type f | grep -i docker | xargs grep -i tendermint
./test/e2e/pkg/infra/docker/docker.go:  e2e "github.com/tendermint/tendermint/test/e2e/pkg"
./test/e2e/pkg/infra/docker/docker.go:  "github.com/tendermint/tendermint/test/e2e/pkg/infra"

As can be seen, I haven't touched the go package names, as this is under another item

PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

@sergio-mena sergio-mena requested review from a team as code owners January 13, 2023 19:46
@sergio-mena sergio-mena mentioned this pull request Jan 13, 2023
Closed
@sergio-mena sergio-mena self-assigned this Jan 13, 2023
@sergio-mena sergio-mena marked this pull request as draft January 13, 2023 20:06
@sergio-mena sergio-mena marked this pull request as ready for review January 13, 2023 22:28
thanethomson
thanethomson approved these changes Jan 14, 2023
View reviewed changes
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks @sergio-mena! I've created the corresponding cometbft/cometbft image repository on Docker Hub and have given the "automation" team (i.e. the bftbot) access to push images: https://hub.docker.com/repository/docker/cometbft/cometbft/general

@sergio-mena
Copy link
Collaborator Author

sergio-mena commented Jan 16, 2023

I've created the corresponding cometbft/cometbft image repository on Docker Hub

Thanks a lot @thanethomson !

@sergio-mena sergio-mena merged commit d9cae0c into main Jan 16, 2023
@sergio-mena sergio-mena deleted the sergio/103-update-test-infra branch January 16, 2023 09:35
sergio-mena added a commit that referenced this pull request Jan 16, 2023
@sergio-mena
[cherry-picked] Renaming in docker-related files (#110)
a3da24d 
* Performed renaming in docker-related files

* Fix e2e launch

* one more
@sergio-mena sergio-mena mentioned this pull request Jan 16, 2023
Merged
3 tasks
sergio-mena added a commit that referenced this pull request Jan 17, 2023
@sergio-mena
Fix e2e nightlies in CI, broken by #110 (#138)
fc48e6f 
* Rename TENDERMINT_BUILD_OPTIONS to COMETBFT_BUILD_OPTIONS all over

* Linter error
@cason
Copy link

cason commented Jan 17, 2023

Hi, I'm afraid that the changes in /spec/ivy-proofs will have to be reverted. Tendermint is used in that Docker referring to the consensus algorithm, not the blockchain solution. Moreover, this is a work done by a third-party company, not by us.

@sergio-mena
Copy link
Collaborator Author

sergio-mena commented Jan 17, 2023

@cason I agree in the occurrences of tendermint-proof. For the executable, etc, I still think it should be called comet.

Even if it was done by a third party, we are the maintainers of this fork, so it's up to us to decide what to do.

I'll open another PR to revert cometbft-proof to tendermint-proof.

@sergio-mena sergio-mena mentioned this pull request Jan 18, 2023
Merged
3 tasks
sergio-mena added a commit that referenced this pull request Jan 18, 2023
@sergio-mena
[backport] Renaming in docker-related files (#123)
42d3afb 
* [cherry-picked] Renaming in docker-related files (#110)

* Performed renaming in docker-related files

* Fix e2e launch

* one more

* revert rename of tendermint-docker.yml

* unrevert renaming tendermint-docker.yml

* Rename TENDERMINT_BUILD_OPTIONS to COMETBFT_BUILD_OPTIONS all over

* Linter error

* Revert `cometbft-proof` to `tendermint-proof`

* Replaced TENDERMINT_VERSION --> COMETBFT_VERSION all over the codebase
sergio-mena added a commit that referenced this pull request Jan 18, 2023
@sergio-mena
[backport] Renaming in docker-related files (#123)
bd95985 
* [cherry-picked] Renaming in docker-related files (#110)

* Performed renaming in docker-related files

* Fix e2e launch

* Rename TENDERMINT_BUILD_OPTIONS to COMETBFT_BUILD_OPTIONS all over

* Revert `cometbft-proof` to `tendermint-proof`

* Replaced TENDERMINT_VERSION --> COMETBFT_VERSION all over the codebase
sergio-mena added a commit that referenced this pull request Jan 19, 2023
@sergio-mena @thanethomson
Rename binary and Docker (#152)
21d783e 
* [backport] Renaming in docker-related files (#123)

* [cherry-picked] Renaming in docker-related files (#110)

* Performed renaming in docker-related files

* Fix e2e launch

* Rename TENDERMINT_BUILD_OPTIONS to COMETBFT_BUILD_OPTIONS all over

* Revert `cometbft-proof` to `tendermint-proof`

* Replaced TENDERMINT_VERSION --> COMETBFT_VERSION all over the codebase

* [backport] Rename inside `test/e2e` (#139) (#144)

* Renamed all help text for cometbft CLI

* Update networks/local/localnode/Dockerfile

Co-authored-by: Thane Thomson <connect@thanethomson.com>

Co-authored-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thanethomson thanethomson thanethomson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sergio-mena sergio-mena

Labels

None yet

Projects

No open projects
CometBFT 2023
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sergio-mena @cason @thanethomson