feat: make handshake cancelable (backport #857)#1013
Merged
sergio-mena merged 2 commits intocometbft:v0.37.xfrom Sep 5, 2023
Merged
feat: make handshake cancelable (backport #857)#1013sergio-mena merged 2 commits intocometbft:v0.37.xfrom
sergio-mena merged 2 commits intocometbft:v0.37.xfrom
Conversation
it'll make the handshake work with graceful shutdown(see: cosmos/cosmos-sdk#16202) handshake could be a long running process if there are many local blocks to replay, for example we use it to do profiling. Hope we can backport this to 0.34.x. --- - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
sergio-mena
reviewed
Jun 21, 2023
|
|
||
| // Replay blocks up to the latest in the blockstore. | ||
| _, err = h.ReplayBlocks(h.initialState, appHash, blockHeight, proxyApp) | ||
| appHash, err = h.ReplayBlocksWithContext(ctx, h.initialState, appHash, blockHeight, proxyApp) |
Collaborator
There was a problem hiding this comment.
I know in future branches the original here re-writes appHash, but not here. I'd leave it as is unless we understand why we are making that change.
Contributor
Author
There was a problem hiding this comment.
I think it's kind of bug fix, previously the log don't output latest hash, but I'm ok that we change that in a separate PR
Contributor
Author
There was a problem hiding this comment.
hi @sergio-mena , do you want me to revert this line?
This makes the log outputs the latest hash, and it only affects the log content.
Collaborator
There was a problem hiding this comment.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
sergio-mena
approved these changes
Sep 5, 2023
3 tasks
g3ndo9kar9
pushed a commit
to skip-mev/cometbft
that referenced
this pull request
Jan 16, 2024
it'll make the handshake work with graceful shutdown(see: cosmos/cosmos-sdk#16202) handshake could be a long running process if there are many local blocks to replay, for example we use it to do profiling. Hope we can backport this to 0.34.x. --- - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
This was referenced Feb 25, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it'll make the handshake work with graceful shutdown(see: cosmos/cosmos-sdk#16202)
handshake could be a long running process if there are many local blocks to replay, for example we use it to do profiling.
.changelog(we use unclog to manage our changelog)docs/orspec/) and code commentsPR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments