Conversation
015a9d6 to
e9072dc
Compare
2cee8a9 to
ce7b92c
Compare
Contributor
|
Was it a lot of work to do this? Asking because we'll need to do this for the |
Contributor
thanethomson
left a comment
There was a problem hiding this comment.
Thanks for this Lásaro!
Doing a grep -E '\stm[a-z]+ "github' **/*.go through your branch though, I still see the following import aliases:
cmd/tendermint/commands/root.go: tmflags "github.com/tendermint/tendermint/libs/cli/flags"
consensus/byzantine_test.go: tmcons "github.com/tendermint/tendermint/proto/tendermint/consensus"
consensus/invalid_test.go: tmcons "github.com/tendermint/tendermint/proto/tendermint/consensus"
consensus/msgs.go: tmcons "github.com/tendermint/tendermint/proto/tendermint/consensus"
consensus/msgs_test.go: tmcons "github.com/tendermint/tendermint/proto/tendermint/consensus"
consensus/reactor.go: tmevents "github.com/tendermint/tendermint/libs/events"
consensus/reactor.go: tmcons "github.com/tendermint/tendermint/proto/tendermint/consensus"
consensus/reactor_test.go: tmcons "github.com/tendermint/tendermint/proto/tendermint/consensus"
consensus/state.go: tmevents "github.com/tendermint/tendermint/libs/events"
consensus/wal.go: tmcons "github.com/tendermint/tendermint/proto/tendermint/consensus"
consensus/wal_test.go: tmtypes "github.com/tendermint/tendermint/types"
crypto/merkle/proof.go: tmcrypto "github.com/tendermint/tendermint/proto/tendermint/crypto"
crypto/merkle/proof_op.go: tmcrypto "github.com/tendermint/tendermint/proto/tendermint/crypto"
crypto/merkle/proof_test.go: tmcrypto "github.com/tendermint/tendermint/proto/tendermint/crypto"
crypto/merkle/proof_value.go: tmcrypto "github.com/tendermint/tendermint/proto/tendermint/crypto"
inspect/inspect.go: tmstrings "github.com/tendermint/tendermint/libs/strings"
libs/bits/bit_array.go: tmprotobits "github.com/tendermint/tendermint/proto/tendermint/libs/bits"
libs/cli/flags/log_level_test.go: tmflags "github.com/tendermint/tendermint/libs/cli/flags"
p2p/node_info.go: tmstrings "github.com/tendermint/tendermint/libs/strings"
p2p/peer.go: tmconn "github.com/tendermint/tendermint/p2p/conn"
p2p/peer_test.go: tmconn "github.com/tendermint/tendermint/p2p/conn"
store/store.go: tmstore "github.com/tendermint/tendermint/proto/tendermint/store"
store/store_test.go: tmstore "github.com/tendermint/tendermint/proto/tendermint/store"
test/e2e/node/main.go: tmnet "github.com/tendermint/tendermint/libs/net"
Contributor
Author
I think that we can automate at least the aliasing safely, which will reduce the work considerably. |
Contributor
Author
|
I guess my grep wasn't as extensive (using the IDE, actually). Thanks for catching. Fixed now! |
thanethomson
approved these changes
Jan 16, 2023
sergio-mena
approved these changes
Jan 16, 2023
Collaborator
There was a problem hiding this comment.
Thanks @sergio-mena.
I did the change here and didn't find any occurrences.
cometcrafter
pushed a commit
to graphprotocol/cometbft
that referenced
this pull request
Jun 25, 2024
…/v0.37.4/pr-101 perf(consensus): Run broadcast routines out of process cometbft#3180 (backport cometbft#101)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #100
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed