Refs #2357
|
isNil := vote.BlockID.IsNil() |
|
extSignature := (len(v.ExtensionSignature) > 0) |
|
if extSignature == (!isPrecommit || isNil) { |
|
// Non-recoverable because the vote is malformed |
|
return false, &ErrVoteExtensionInvalid{ExtSignature: v.ExtensionSignature} |
|
} |
Currently, we require an extension signature from the privval EVEN IF vote extensions are disabled. I.e., if the app is not using vote extensions, validators are signing (through HSM or FilePV) empty Vote.Extension (plus other fields like height and round). Seems like a waste of computing resources. Refs iqlusioninc/tmkms#857 (comment)
Refs #2357
cometbft/types/vote.go
Lines 436 to 441 in 914e9d7
Currently, we require an extension signature from the privval EVEN IF vote extensions are disabled. I.e., if the app is not using vote extensions, validators are signing (through HSM or
FilePV) emptyVote.Extension(plus other fields like height and round). Seems like a waste of computing resources. Refs iqlusioninc/tmkms#857 (comment)