Skip to content

privval: DO NOT require extension signature from privval if vote extension is disabled #2439

New issue
New issue
Closed
#2496
Closed
privval: DO NOT require extension signature from privval if vote extension is disabled#2439
#2496
Assignees
melekes
Labels
enhancementNew feature or requestprivval
Milestone
2024-Q1
@melekes

Description

@melekes
melekes
opened on Feb 26, 2024

Refs #2357

cometbft/types/vote.go

Lines 436 to 441 in 914e9d7

isNil := vote.BlockID.IsNil()
extSignature := (len(v.ExtensionSignature) > 0)
if extSignature == (!isPrecommit || isNil) {
// Non-recoverable because the vote is malformed
return false, &ErrVoteExtensionInvalid{ExtSignature: v.ExtensionSignature}
}

Currently, we require an extension signature from the privval EVEN IF vote extensions are disabled. I.e., if the app is not using vote extensions, validators are signing (through HSM or FilePV) empty Vote.Extension (plus other fields like height and round). Seems like a waste of computing resources. Refs iqlusioninc/tmkms#857 (comment)

Metadata

Metadata

Assignees

Labels

enhancementNew feature or requestprivval

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions