Improvements for reconstruction normalization / bbox / centroid #3047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahojnnes
commented
Dec 16, 2024
sarlinpe
reviewed
Dec 16, 2024
sarlinpe
reviewed
Dec 16, 2024
sarlinpe
approved these changes
Dec 16, 2024
HernandoR
pushed a commit
to HernandoR/colmap
that referenced
this pull request
Dec 30, 2024
…ap#3047) * Use nth_element instead of sort for faster ordering. * Normalize in double precision to better handle large coordinates (e.g., GPS). * Use Eigen's AlignedBox instead of pair of Vector3d for bbox. * Extract bbox and centroid computation into reusable geometry module function. Add some more tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.