docs: Document Claude Code command fix investigation#688
Conversation
This documents the investigation into the reported Claude Code command error. The main branch already uses the correct --transport syntax instead of --type.
WalkthroughAdds a new documentation file clarifying correct Claude Code command usage, contrasting an incorrect flag (--type http) with the correct flag (--transport http), noting current repository status, listing checked files, and advising deployment updates to match main. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
docs/CLAUDE_CODE_COMMAND_FIX.md (5)
21-23: Avoid fragile “Line N” references; they drift.Drop line numbers or replace with commit permalinks to prevent staleness.
Apply this diff:
-1. **docs/docs/mcp-overview.mdx** - Line 81: Uses `--transport sse` (correct for SSE) -2. **docs/docs/mcp-server.mdx** - Line 99: Uses `--transport sse` (correct for SSE) -3. **archon-ui-main/src/features/mcp/components/McpConfigSection.tsx** - Line 191: Uses `--transport http` (correct for HTTP) +1. **docs/docs/mcp-overview.mdx**: Uses `--transport sse` (correct for SSE) +2. **docs/docs/mcp-server.mdx**: Uses `--transport sse` (correct for SSE) +3. **archon-ui-main/src/features/mcp/components/McpConfigSection.tsx**: Uses `--transport http` (correct for HTTP)
26-26: Remove/anonymize the bare IP; also fixes markdownlint MD034.Public IPs in docs can leak infra details and violate “no-bare-urls”.
Apply this diff:
-The main branch already contains the correct syntax. If the deployed instance at http://68.183.152.55:3737/mcp is showing the incorrect command, it may be running an older version of the code that needs to be updated. +The main branch already contains the correct syntax. If a deployed instance is showing the incorrect command, it may be running an older version of the code that needs to be updated.Optionally add a generic placeholder elsewhere (e.g.,
<http://YOUR_HOST:PORT/mcp>).
18-23: Add “Last verified” and a local verification snippet.Helps future readers validate claims quickly and keep this doc evergreen.
Apply this diff:
After investigation of the current codebase, all instances of the Claude Code command in the repository already use the correct `--transport http` syntax: +> Last verified: 2025-09-17 against `main`. + 1. **docs/docs/mcp-overview.mdx**: Uses `--transport sse` (correct for SSE) 2. **docs/docs/mcp-server.mdx**: Uses `--transport sse` (correct for SSE) 3. **archon-ui-main/src/features/mcp/components/McpConfigSection.tsx**: Uses `--transport http` (correct for HTTP) ## Resolution @@ - ✅ No instances of `--type http` found in the codebase + +## How to verify locally +```sh +rg -n --hidden -S --glob '!.git' -e '\b--type\s+(http|sse)\b' -e '\b--transport\s+(http|sse)\b' +``` +Expect: zero matches for `--type http` or `--type sse`; matches should use `--transport`.Also applies to: 29-31
1-4: If this should appear on the docs site, add Docusaurus frontmatter/move file.If published via Docusaurus (repo uses docs/docs/), move this into docs/docs/ and add frontmatter; otherwise keep as internal root‑level doc.
Suggested frontmatter:
--- title: Claude Code command fix investigation slug: claude-code-command-fix sidebar_position: 999 ---
33-34: Optional: add a CI guard to prevent regressions.Fail PRs that reintroduce
--type http.Add a lightweight step:
- name: Guard against deprecated Claude MCP flags run: | rg -n --hidden -S --glob '!.git' '\b--type\s+http\b' && { echo "Found deprecated flag --type http"; exit 1; } || true
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/CLAUDE_CODE_COMMAND_FIX.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/CLAUDE_CODE_COMMAND_FIX.md
26-26: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (1)
docs/CLAUDE_CODE_COMMAND_FIX.md (1)
1-17: Clear, useful incident write‑up.The problem statement, incorrect vs. correct command, and remediation are concise and accurate. Nice.
|
hey, thanks for the PR. Which issue/report you refering too? I dont see anything linked. Other than that I dont think we should do additional documentation for such stuff, cause the UI (as you state) already shows the correct commands and the users can just copy it from there. |
|
Thank you for this PR |
* feat: add per-node MCP servers for DAG workflows (#445) Add `mcp: path/to/config.json` field to DAG workflow nodes. At execution time, the executor reads the MCP config JSON, expands $VAR_NAME env references in env/headers values, and passes the loaded servers to the Claude Agent SDK via Options.mcpServers. MCP tool wildcards are auto- added to allowedTools. - Add mcp field to DagNodeBase type and loader validation - Add mcpServers + allowedTools to WorkflowAssistantOptions and AssistantRequestOptions - Pass mcpServers/allowedTools through ClaudeClient to SDK Options - Handle system/init message to detect MCP connection failures - Add Codex warning (per-node MCP not supported) - Add Haiku warning (tool search not supported) - Add MCP config path input in Web UI NodeInspector - Add mcp to WorkflowCanvas reactFlowToDagNodes conversion - Add 12 unit tests for loadMcpConfig and env var expansion * fix: address review findings for per-node MCP servers Type safety: - Use SDK McpServerConfig type in AssistantRequestOptions (eliminates unsafe cast) - Update WorkflowAssistantOptions.mcpServers to proper discriminated union - Remove redundant cast in claude.ts Error handling: - Warn users when MCP config references undefined env vars - Check safeSendMessage return value for MCP connection failures - Check safeSendMessage return value for Haiku MCP warning - Log unhandled system messages at debug level in both claude.ts and dag-executor.ts - Coerce non-string env/header values with warning instead of silent passthrough Code quality: - Fix log event naming: dag_node_mcp_* → dag.mcp_* (domain.action_state format) - Replace IIFE in loader mcp validation with plain if/else - Extract duplicated env expansion logic into expandEnvVarsInRecord helper - Merge split import from ./deps into single statement - Return missingVars from loadMcpConfig/expandEnvVars for caller awareness Documentation: - Add mcp field to Node Fields table in docs/authoring-workflows.md - Add mcp to DAG schema example, allowed_tools section, and summary list - Add mcp to CLAUDE.md DAG feature list - Add per-node MCP servers paragraph to README.md tool restrictions section * docs: add MCP servers guide (docs/mcp-servers.md) Comprehensive guide covering config file format (stdio/HTTP/SSE), env var expansion, automatic tool wildcards, MCP-only nodes, connection failure handling, workflow examples, troubleshooting, and popular server list. Cross-referenced from authoring-workflows.md and CLAUDE.md. * feat: add optional ntfy push notification to smart PR review Add conditional notify node to archon-smart-pr-review workflow that sends a push notification when the review completes. Gated behind a bash node that checks for .archon/mcp/ntfy.json — silently skipped if not configured. - Add check-ntfy bash node + notify MCP node to smart PR review workflow - Add .archon/mcp/ to .gitignore (per-user MCP configs may contain secrets) - Add "Push Notifications" setup guide to docs/mcp-servers.md
…am00#688) * feat: add per-node MCP servers for DAG workflows (coleam00#445) Add `mcp: path/to/config.json` field to DAG workflow nodes. At execution time, the executor reads the MCP config JSON, expands $VAR_NAME env references in env/headers values, and passes the loaded servers to the Claude Agent SDK via Options.mcpServers. MCP tool wildcards are auto- added to allowedTools. - Add mcp field to DagNodeBase type and loader validation - Add mcpServers + allowedTools to WorkflowAssistantOptions and AssistantRequestOptions - Pass mcpServers/allowedTools through ClaudeClient to SDK Options - Handle system/init message to detect MCP connection failures - Add Codex warning (per-node MCP not supported) - Add Haiku warning (tool search not supported) - Add MCP config path input in Web UI NodeInspector - Add mcp to WorkflowCanvas reactFlowToDagNodes conversion - Add 12 unit tests for loadMcpConfig and env var expansion * fix: address review findings for per-node MCP servers Type safety: - Use SDK McpServerConfig type in AssistantRequestOptions (eliminates unsafe cast) - Update WorkflowAssistantOptions.mcpServers to proper discriminated union - Remove redundant cast in claude.ts Error handling: - Warn users when MCP config references undefined env vars - Check safeSendMessage return value for MCP connection failures - Check safeSendMessage return value for Haiku MCP warning - Log unhandled system messages at debug level in both claude.ts and dag-executor.ts - Coerce non-string env/header values with warning instead of silent passthrough Code quality: - Fix log event naming: dag_node_mcp_* → dag.mcp_* (domain.action_state format) - Replace IIFE in loader mcp validation with plain if/else - Extract duplicated env expansion logic into expandEnvVarsInRecord helper - Merge split import from ./deps into single statement - Return missingVars from loadMcpConfig/expandEnvVars for caller awareness Documentation: - Add mcp field to Node Fields table in docs/authoring-workflows.md - Add mcp to DAG schema example, allowed_tools section, and summary list - Add mcp to CLAUDE.md DAG feature list - Add per-node MCP servers paragraph to README.md tool restrictions section * docs: add MCP servers guide (docs/mcp-servers.md) Comprehensive guide covering config file format (stdio/HTTP/SSE), env var expansion, automatic tool wildcards, MCP-only nodes, connection failure handling, workflow examples, troubleshooting, and popular server list. Cross-referenced from authoring-workflows.md and CLAUDE.md. * feat: add optional ntfy push notification to smart PR review Add conditional notify node to archon-smart-pr-review workflow that sends a push notification when the review completes. Gated behind a bash node that checks for .archon/mcp/ntfy.json — silently skipped if not configured. - Add check-ntfy bash node + notify MCP node to smart PR review workflow - Add .archon/mcp/ to .gitignore (per-user MCP configs may contain secrets) - Add "Push Notifications" setup guide to docs/mcp-servers.md
…am00#688) * feat: add per-node MCP servers for DAG workflows (coleam00#445) Add `mcp: path/to/config.json` field to DAG workflow nodes. At execution time, the executor reads the MCP config JSON, expands $VAR_NAME env references in env/headers values, and passes the loaded servers to the Claude Agent SDK via Options.mcpServers. MCP tool wildcards are auto- added to allowedTools. - Add mcp field to DagNodeBase type and loader validation - Add mcpServers + allowedTools to WorkflowAssistantOptions and AssistantRequestOptions - Pass mcpServers/allowedTools through ClaudeClient to SDK Options - Handle system/init message to detect MCP connection failures - Add Codex warning (per-node MCP not supported) - Add Haiku warning (tool search not supported) - Add MCP config path input in Web UI NodeInspector - Add mcp to WorkflowCanvas reactFlowToDagNodes conversion - Add 12 unit tests for loadMcpConfig and env var expansion * fix: address review findings for per-node MCP servers Type safety: - Use SDK McpServerConfig type in AssistantRequestOptions (eliminates unsafe cast) - Update WorkflowAssistantOptions.mcpServers to proper discriminated union - Remove redundant cast in claude.ts Error handling: - Warn users when MCP config references undefined env vars - Check safeSendMessage return value for MCP connection failures - Check safeSendMessage return value for Haiku MCP warning - Log unhandled system messages at debug level in both claude.ts and dag-executor.ts - Coerce non-string env/header values with warning instead of silent passthrough Code quality: - Fix log event naming: dag_node_mcp_* → dag.mcp_* (domain.action_state format) - Replace IIFE in loader mcp validation with plain if/else - Extract duplicated env expansion logic into expandEnvVarsInRecord helper - Merge split import from ./deps into single statement - Return missingVars from loadMcpConfig/expandEnvVars for caller awareness Documentation: - Add mcp field to Node Fields table in docs/authoring-workflows.md - Add mcp to DAG schema example, allowed_tools section, and summary list - Add mcp to CLAUDE.md DAG feature list - Add per-node MCP servers paragraph to README.md tool restrictions section * docs: add MCP servers guide (docs/mcp-servers.md) Comprehensive guide covering config file format (stdio/HTTP/SSE), env var expansion, automatic tool wildcards, MCP-only nodes, connection failure handling, workflow examples, troubleshooting, and popular server list. Cross-referenced from authoring-workflows.md and CLAUDE.md. * feat: add optional ntfy push notification to smart PR review Add conditional notify node to archon-smart-pr-review workflow that sends a push notification when the review completes. Gated behind a bash node that checks for .archon/mcp/ntfy.json — silently skipped if not configured. - Add check-ntfy bash node + notify MCP node to smart PR review workflow - Add .archon/mcp/ to .gitignore (per-user MCP configs may contain secrets) - Add "Push Notifications" setup guide to docs/mcp-servers.md
Summary
This PR documents the investigation into a reported error in the Claude Code MCP configuration command.
Issue Report
A user reported that the documentation at
http://68.183.152.55:3737/mcpshowed an incorrect Claude Code command:The correct command should be:
Investigation Results
After thorough investigation of the current codebase:
✅ All documentation files already use the correct
--transportsyntaxdocs/docs/mcp-overview.mdx- Uses--transport sse(correct for SSE)docs/docs/mcp-server.mdx- Uses--transport sse(correct for SSE)archon-ui-main/src/features/mcp/components/McpConfigSection.tsx- Uses--transport http(correct for HTTP)✅ No instances of
--type httpfound in the main branchRoot Cause
The main branch already contains the correct syntax. The deployed instance showing the incorrect command may be running an older version of the code.
Resolution
This PR adds documentation of the investigation to help maintainers understand that:
Files Added
docs/CLAUDE_CODE_COMMAND_FIX.md- Documents the investigation and current status🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com
Summary by CodeRabbit