Summary

• Problem: The gate node in maintainer-review-pr was the workflow's most fragile point. Pi/Minimax intermittently wrapped the verdict JSON in a markdown fence or prefixed reasoning prose, which broke the condition-evaluator's field extraction. When that happened the DAG silently skipped every downstream aspect and the workflow exited 0 — a "successful" run that posted no review and surfaced no error (the silent-failure cascade tracked separately in Workflow exits success when condition_json_parse_failed cascades to silent node skips #1673).
• Why it matters: Hand-picked PRs from the morning standup brief never benefited from the gate. Across ~13 production runs over two days the gate returned verdict: review every single time; the decline / needs_split / unclear branches were never exercised. So the gate added all of the failure mode and none of the signal.
• What changed: Removed the gate path entirely (gate, approve-decline, post-decline, approve-unclear, plus the read-context node that only fed the gate). Rewired review-classify to depend directly on [fetch-pr, fetch-diff]. Updated the synthesize and report commands and deleted the now-orphan gate command. record-review hard-codes gate_verdict: 'review' for back-compat with the standup brief's reviewed/declined/triaged marker logic.
• What did not change (scope boundary): No engine code touched. No @archon/workflows changes. Bundled defaults untouched (bun run check:bundled clean). The standup workflow and its persist script are unchanged — those handle their own (unrelated) Pi-format quirks. The decline/needs_split workflow path is gone for now; if/when automated PR triage is introduced, the gate (with a hardened parser or Claude provider) can be added back in a separate workflow.

UX Journey

Before

User                              Archon
────                              ──────
runs maintainer-review-pr 1554 ▶  extract-pr  →  fetch-pr + fetch-diff + read-context
                                              ▼
                                  gate (Pi, ~1m) → JSON verdict
                                              ▼
                          ┌───────────────────┼──────────────────────────┐
                  [verdict=review]   [verdict=decline]            [verdict=unclear]
                          ▼                   ▼                          ▼
                  review-classify       approve-decline (human)    approve-unclear (human)
                          ▼                   ▼
                  5 aspects (parallel)  post-decline
                          ▼                   ▼
                  synthesize           record-review
                          ▼                   ▼
                  post-review          report
                          ▼                   ▼
sees draft + posted comment    (or)    sees decline outcome

Failure mode (observed twice yesterday):

                                  gate emits ```json\n{verdict: review,...}\n```
                                              ▼
                  condition-evaluator: parse fails (warn log only)
                  $gate.output.verdict missing → all when: clauses falsy
                  [X] every aspect node Skipped (when_condition)
                  workflow exits 0
sees "Workflow completed successfully" — but no review was actually run.

After

User                              Archon
────                              ──────
runs maintainer-review-pr 1554 ▶  extract-pr  →  fetch-pr → fetch-diff
                                                                 ▼
                                                          review-classify (Pi)
                                                                 ▼
                                                          5 aspects (parallel, gated by classifier)
                                                                 ▼
                                                          synthesize
                                                                 ▼
                                                          [+] post-review
                                                                 ▼
                                                          record-review
                                                                 ▼
                                                          report
sees draft + posted comment

Architecture Diagram

Before

+----------------------+        +----------------------+        +----------------------+
| extract-pr-number    | -----> | fetch-pr             | -----> | gate (Pi command)    |
+----------------------+        | fetch-diff           |        +----------------------+
                                | read-context (script)|             |   |   |
                                +----------------------+             v   v   v
                                                      review-classify  decline  unclear
                                                              |          |        |
                                                              v          v        v
                                                       5 aspects    post-decline  (manual)
                                                              \         /
                                                               v       v
                                                              record-review
                                                                   v
                                                                  report

After

+----------------------+        +----------------------+
| extract-pr-number    | -----> | fetch-pr             |
+----------------------+        | fetch-diff           |
                                +----------------------+
                                          v
                                review-classify
                                          v
                                5 aspects (parallel)
                                          v
                                synthesize-review
                                          v
                                post-review
                                          v
                                record-review
                                          v
                                report

Connection inventory:

Label Snapshot

• Risk: risk: low
• Size: size: M (-426 net lines; mostly deletions)
• Scope: workflows
• Module: workflows:maintainer-review

Change Metadata

• Change type: chore (workflow simplification; no engine code touched)
• Primary scope: workflows

Linked Issue

• Closes # none
• Related Workflow exits success when condition_json_parse_failed cascades to silent node skips #1673 — silent-skip cascade on condition_json_parse_failed. This PR removes the workflow path that triggers Workflow exits success when condition_json_parse_failed cascades to silent node skips #1673 most often, but it does NOT fix the engine bug. Workflow exits success when condition_json_parse_failed cascades to silent node skips #1673 stays open as a fail-loud improvement to the condition-evaluator.

Validation Evidence (required)

$ bun run validate
# All six steps passed (check:bundled, check:bundled-skill, type-check, lint, format:check, test)

$ bun run cli validate workflows
# Results: 36 valid, 0 with errors

$ bun run cli workflow run maintainer-review-pr "1554"
# End-to-end smoke test on this branch:
#   extract-pr-number  15.3s
#   fetch-pr           838ms      (parallel with fetch-diff)
#   fetch-diff         525ms
#   review-classify    58s
#   code-review        6m51s      (only aspect classifier picked for this PR)
#   synthesize         1m43s
#   post-review        1.3s       (posted to PR #1554)
#   record-review      35ms
#   report             35.8s
# Total ~12 min, exit 0, 0 condition_json_parse_failed events.

• Evidence provided: full validate suite passes; workflow validation clean across all 36 workflows; one end-to-end smoke run on PR fix(adapters): place webhook clones in workspace source/ subdirectory #1554 with the new shape, comment posted successfully, reviewed-prs.json updated correctly.
• If any command is intentionally skipped: none.

Security Impact (required)

• New permissions/capabilities? No
• New external network calls? No (same gh pr view / gh pr diff / gh pr comment calls as before)
• Secrets/tokens handling changed? No
• File system access scope changed? No

Compatibility / Migration

• Backward compatible? Yes for the standup brief's reviewed-prs.json reader. Old entries with gate_verdict: 'decline' | 'needs_split' | 'unclear' are still read correctly. New entries are always gate_verdict: 'review', which the standup synth treats as "reviewed Nd ago" — the natural behavior we want.
• Config/env changes? No
• Database migration needed? No

Human Verification (required)

• Verified scenarios:
  • Smoke ran maintainer-review-pr "1554" end-to-end on this branch and confirmed the posted comment on the PR.
  • Confirmed reviewed-prs.json got the new entry with gate_verdict: 'review'.
  • Inspected reviewed-prs.json to confirm existing entries with gate_verdict: 'decline' | 'needs_split' | 'unclear' still parse fine (no schema change).
  • Ran bun run cli validate workflows to confirm all 36 workflows still load.
• Edge cases checked:
  • Workflow with interactive: false (was true) runs fine on CLI; foreground execution on Web is not required without approval gates.
  • Synthesize command no longer reads $ARTIFACTS_DIR/gate-decision.md; smoke confirmed no spurious "Gate-decision notes" section in the synthesis output.
• What was not verified: did not run any of the other 35 workflows (none depend on the deleted gate command).

Side Effects / Blast Radius (required)

• Affected subsystems/workflows: maintainer-review-pr only.
• Potential unintended effects: the standup brief's "Replies waiting" / "✓ reviewed" markers depend on gate_verdict in reviewed-prs.json. With every new entry being 'review', the standup synth's declined / triaged (unclear) branches will only ever match older entries — which is the intended outcome.
• Guardrails/monitoring for early detection: run the workflow on a fresh PR; if anything regresses we'll see it in the standup's next-day brief (the PR will be missing the ✓ reviewed Nd ago marker).

Rollback Plan (required)

• Fast rollback command/path: revert the merge commit; the prior workflow file is restored verbatim. There is no engine state to migrate back.
• Feature flags or config toggles (if any): none — this is a project workflow file.
• Observable failure symptoms: review-classify or any aspect node fails with a missing-context error. (Unlikely — review-classify already had access to fetch-pr / fetch-diff content via gate upstream, which is what we wire directly now.)

Risks and Mitigations

• Risk: A future PR contributed by someone unfamiliar with Archon's direction is reviewed deeply when a polite decline would have been the right answer.
  • Mitigation: the maintainer is the one running this workflow on PRs they've already chosen from the standup brief. The standup brief's P4 "Polite-decline candidates" section already surfaces those PRs separately; this workflow is for PRs the maintainer has decided to review. If automated PR triage is ever wired up, reintroduce the gate (with a hardened parser or Claude provider on that specific node) in a separate workflow rather than this one.
• Risk: Project-local workflow file edits drift away from bundled defaults over time.
  • Mitigation: bun run check:bundled and bun run check:bundled-skill still pass (this workflow is not in defaults/).

Summary by CodeRabbit

Refactor

• Streamlined the maintainer review workflow by removing intermediate gating decision phases, enabling reviews to proceed directly from classification through synthesis to automated comment posting
• Simplified review output templates to focus on core findings and outcomes
• Updated internal state tracking to align with the new streamlined review process