Skip to content

fix(marketplace-auto-review): silence loader Pino logs in validate-schema#1644

Merged
coleam00 merged 1 commit into
devfrom
fix/validate-schema-silence-loader-logs
May 11, 2026
Merged

fix(marketplace-auto-review): silence loader Pino logs in validate-schema#1644
coleam00 merged 1 commit into
devfrom
fix/validate-schema-silence-loader-logs

Conversation

@coleam00

@coleam00 coleam00 commented May 11, 2026

Copy link
Copy Markdown
Owner

validate-schema stdout was being polluted by parseWorkflow's Pino warnings (workflow_missing_description, etc.) which then broke the decide node's substitution. Set log level to fatal before any parseWorkflow call. Fifth iteration.

Summary by CodeRabbit

  • Chores
    • Reduced log verbosity in the marketplace schema validation script to prevent warning noise from disrupting parsing output while maintaining validation accuracy.

Review Change Stack

…hema

parseWorkflow logs warnings via Pino at default stdout. validate-schema's stdout is consumed by the decide node via variable substitution into a TypeScript expression, so any non-JSON log line breaks the substituted script. Set log level to fatal before parseWorkflow runs to suppress warnings cleanly. Long-term, the platform logger should write to stderr instead of stdout for CLI tool ergonomics, but that's a broader cross-cutting change.
@coleam00 coleam00 merged commit 0d4cf07 into dev May 11, 2026
1 check was pending
@coleam00 coleam00 deleted the fix/validate-schema-silence-loader-logs branch May 11, 2026 16:39
@coderabbitai

coderabbitai Bot commented May 11, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: abc0e3e8-c6fd-4f48-8e7e-78e57895d85c

📥 Commits

Reviewing files that changed from the base of the PR and between 17437bd and 2a9080f.

📒 Files selected for processing (1)
  • .archon/scripts/marketplace-validate-schema.ts

📝 Walkthrough

Walkthrough

The marketplace schema validation script now suppresses loader output by importing and configuring the logger to 'fatal' level before parsing workflows, preventing warning noise from disrupting validation execution.

Changes

Logger Configuration

Layer / File(s) Summary
Logger Setup
.archon/scripts/marketplace-validate-schema.ts
Import setLogLevel function and call setLogLevel('fatal') before parseWorkflow to suppress loader logging output without changing validation logic or return shape.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A logger so chatty, so full of its cheer,
Now silenced to fatal—no warnings we'll hear!
Our workflows parse clean, with nary a peep,
The validation runs smooth while the parse logs sleep.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/validate-schema-silence-loader-logs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Wirasm Wirasm mentioned this pull request May 12, 2026
cropse pushed a commit to cropse/Archon that referenced this pull request May 19, 2026
…hema (coleam00#1644)

parseWorkflow logs warnings via Pino at default stdout. validate-schema's stdout is consumed by the decide node via variable substitution into a TypeScript expression, so any non-JSON log line breaks the substituted script. Set log level to fatal before parseWorkflow runs to suppress warnings cleanly. Long-term, the platform logger should write to stderr instead of stdout for CLI tool ergonomics, but that's a broader cross-cutting change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant