fix(marketplace-auto-review): validate-schema always exits 0#1643
Conversation
…e can route invalid submissions validate-schema was exiting 1 when any submitted workflow YAML failed schema validation. The DAG executor treats non-zero exit as node failure, which short-circuits the downstream ai-review / decide / act nodes via trigger_rule. Result: a marketplace PR with an invalid workflow gets no review comment because the workflow crashes before act can post one. Exit 0 always — the JSON output already includes 'valid: false', and decide routes that to 'request_changes' with an actionable comment.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe validation script's exit behavior is modified to always return status code ChangesValidation Exit Code
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…e can route invalid submissions (coleam00#1643) validate-schema was exiting 1 when any submitted workflow YAML failed schema validation. The DAG executor treats non-zero exit as node failure, which short-circuits the downstream ai-review / decide / act nodes via trigger_rule. Result: a marketplace PR with an invalid workflow gets no review comment because the workflow crashes before act can post one. Exit 0 always — the JSON output already includes 'valid: false', and decide routes that to 'request_changes' with an actionable comment.
Lets decide/act route schema-invalid submissions to request_changes with a comment instead of crashing the DAG. Fourth iteration of marketplace-auto-review end-to-end debugging.
Summary by CodeRabbit