Skip to content

fix(marketplace-auto-review): use relative-path import for @archon/workflows/loader#1642

Merged
coleam00 merged 1 commit into
devfrom
fix/workspace-package-resolution-in-archon-scripts
May 11, 2026
Merged

fix(marketplace-auto-review): use relative-path import for @archon/workflows/loader#1642
coleam00 merged 1 commit into
devfrom
fix/workspace-package-resolution-in-archon-scripts

Conversation

@coleam00

@coleam00 coleam00 commented May 11, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Third iteration on the marketplace auto-review end-to-end test. Bun's run-script context for .archon/scripts/ doesn't reliably honor the @archon/workflows/loader subpath export when invoked in CI via 'bun --no-env-file run abs-path'. Switching to a direct relative-path import bypasses the resolution gap.

Summary by CodeRabbit

  • Chores
    • Updated the build validation script to ensure consistent behavior across development and CI environments.

Review Change Stack

@coleam00
fix(marketplace-auto-review): import @archon/workflows/loader by rela…
be6dd24 
…tive path

Bun's run-script context for scripts at .archon/scripts/ doesn't reliably honor the @archon/workflows/loader subpath export when invoked in CI via bun --no-env-file run <abs-path>. Module resolution finds node_modules at the repo root but fails on the subpath. Switch to a direct relative-path import to bypass the resolution gap. Other marketplace scripts (fetch-source, security-scan) don't hit this because they only use node: built-ins.
@coleam00 coleam00 merged commit de87237 into dev May 11, 2026
@coleam00 coleam00 deleted the fix/workspace-package-resolution-in-archon-scripts branch May 11, 2026 15:43
@coderabbitai

coderabbitai Bot commented May 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d6471939-bc7b-4a6d-a7a2-38965fa1defe

📥 Commits

Reviewing files that changed from the base of the PR and between bcb6f80 and be6dd24.

📒 Files selected for processing (1)
  • .archon/scripts/marketplace-validate-schema.ts
📝 Walkthrough

Walkthrough

The marketplace validation schema script changes its dependency resolution strategy by importing parseWorkflow directly from the loader source file (../../packages/workflows/src/loader.ts) instead of using the package subpath import (@archon/workflows/loader), with inline comments documenting the Bun/CI resolution constraint.

Changes

Import Path Resolution

Layer / File(s) Summary
Import Path Update
.archon/scripts/marketplace-validate-schema.ts		 parseWorkflow import switches from @archon/workflows/loader package subpath to direct relative path ../../packages/workflows/src/loader.ts with documentation explaining Bun's run-script context does not resolve the subpath correctly in CI.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A script once stumbled in CI's morning light,
Package paths twisted, imports not quite right,
But lo! A direct path through source files clear,
Bun's resolution gap now bridged with cheer,
Simple and swift, the fix takes flight!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/workspace-package-resolution-in-archon-scripts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Wirasm Wirasm mentioned this pull request May 12, 2026
Merged
cropse pushed a commit to cropse/Archon that referenced this pull request May 19, 2026
@coleam00 @cropse0219
fix(marketplace-auto-review): import @archon/workflows/loader by rela…
90ede88 
…tive path (coleam00#1642)

Bun's run-script context for scripts at .archon/scripts/ doesn't reliably honor the @archon/workflows/loader subpath export when invoked in CI via bun --no-env-file run <abs-path>. Module resolution finds node_modules at the repo root but fails on the subpath. Switch to a direct relative-path import to bypass the resolution gap. Other marketplace scripts (fetch-source, security-scan) don't hit this because they only use node: built-ins.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@coleam00