fix(marketplace-auto-review): multi-line diff parsing + glibc Claude binary pin#1641
Merged
Merged
Conversation
…libc Claude binary Two bugs surfaced when the workflow first ran against a real submission PR: 1. parse-entry regex assumed single-line 'sourceUrl: <value>'. Prettier wraps long values to a new line, and each line in the diff carries a leading '+' that our regex's \s* cannot skip. Strip the '+' prefix from added lines before regex matching. 2. Claude Agent SDK loaded the linux-x64-musl native variant on glibc Ubuntu runners and failed at the missing binary. Mirror the docker-entrypoint fix (PR #1521): after install, locate the glibc binary under node_modules and export CLAUDE_BIN_PATH so the SDK resolver picks it instead of musl.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR refactors workflow configuration in two independent marketplace automation workflows: the marketplace PR review workflow improves diff parsing logic for extracting added entries, and the marketplace auto-review workflow adds CPU architecture detection to pin the Claude CLI binary to the glibc variant. ChangesMarketplace PR Review Workflow Parsing
Marketplace Auto-Review Workflow Binary Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
cropse
pushed a commit
to cropse/Archon
that referenced
this pull request
May 19, 2026
…libc Claude binary (coleam00#1641) Two bugs surfaced when the workflow first ran against a real submission PR: 1. parse-entry regex assumed single-line 'sourceUrl: <value>'. Prettier wraps long values to a new line, and each line in the diff carries a leading '+' that our regex's \s* cannot skip. Strip the '+' prefix from added lines before regex matching. 2. Claude Agent SDK loaded the linux-x64-musl native variant on glibc Ubuntu runners and failed at the missing binary. Mirror the docker-entrypoint fix (PR coleam00#1521): after install, locate the glibc binary under node_modules and export CLAUDE_BIN_PATH so the SDK resolver picks it instead of musl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs surfaced when the marketplace-pr-review-and-merge workflow ran against PR #1639:
parse-entry regex couldn't match multi-line values. Prettier wraps long sourceUrl values to a new line. Each line in the diff carries a '+' prefix; \s* matches whitespace across newlines but cannot skip the '+'. Fix: strip the '+' prefix from added lines before regex matching.
Claude binary musl/glibc mismatch on Ubuntu runners. Bun installs both glibc and musl optional-dep variants; the Claude Agent SDK resolver picks musl first, which fails on glibc Ubuntu. Fix: mirror PR fix(docker): resolve Claude binary to glibc variant on Debian image #1521's docker-entrypoint approach — locate the glibc binary under node_modules and export CLAUDE_BIN_PATH before invoking the workflow.
Verification
End-to-end test is re-running the auto-review against PR #1639 once this lands on dev.
Test plan
Summary by CodeRabbit