Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Review: fix(cli) suppress boot stderr and Pino info logs in archon doctor/setup

Verdict: Approve with one actionable fix and a few optional notes.

The fix is correct and clean for the primary case. One edge case warrants attention before merge.

C1 — LOG_LEVEL=debug archon doctor produces half-verbose state (fix before merge)

Files: packages/cli/src/cli.ts:290-295, packages/paths/src/env-loader.ts:51

When a user has LOG_LEVEL=debug in their environment and runs archon doctor:

1. isVerboseBoot() → true → [archon] loaded N keys lines appear in stderr (correct)
2. isInteractiveCommand && !values.verbose → setLogLevel('warn') → all Pino info/debug events suppressed

The user explicitly signaled debug intent via LOG_LEVEL=debug but gets boot lines without Pino — a contradictory state. --verbose is required to fully re-enable logging, which is undocumented and surprising.

Fix:

const isInteractiveCommand = command === 'setup' || command === 'doctor';
const logLevelIsVerbose = ['debug', 'trace'].includes(
  (process.env.LOG_LEVEL ?? '').toLowerCase()
);
if (values.quiet || (isInteractiveCommand && !values.verbose && !logLevelIsVerbose)) {
  setLogLevel('warn');
} else if (values.verbose) {
  setLogLevel('debug');
}

Alternatively: keep current behavior but document in the comment that LOG_LEVEL=debug only affects boot-time output and --verbose is required for Pino verbosity in interactive commands. This is defensible but should be explicit.

S1 — isVerboseBoot() docstring is too verbose (optional)

File: packages/paths/src/env-loader.ts:45-48

Per CLAUDE.md: one short line max. The four-line JSDoc restates what the function name already says. The non-obvious WHY (runs before parseArgs()) is worth keeping as a single line:

// Verbosity via env vars because this runs before parseArgs() and Pino.
function isVerboseBoot(): boolean {

S2 — isInteractiveCommand is used exactly once (optional)

File: packages/cli/src/cli.ts:290

Assigned on one line, consumed on the next. Per YAGNI, no named variable needed here. Inline it:

if (values.quiet || ((command === 'setup' || command === 'doctor') && !values.verbose)) {

Note: this suggestion would be superseded by the C1 fix above which needs the variable or the logLevelIsVerbose guard.

S3 — Comment block above setLogLevel is one sentence too long (optional)

File: packages/cli/src/cli.ts:285-289

The last sentence about lazy logger initialization is an implementation detail, not a decision. Two sentences cover the intent:

// quiet > verbose > default; setup and doctor default to warn so checklist
// output isn't interleaved with Pino JSON (--verbose re-enables structured logs).

S4 — consoleErrorSpy fixture scope is broader than needed (optional)

File: packages/paths/src/env-loader.test.ts:26-29

consoleErrorSpy is set up in beforeEach and used by exactly one test. Globally scoping it silently swallows unexpected console.error calls in the other seven tests. Moving it inside the one test that needs it makes the test surface explicit.

Docs (update before merge)

Three docs pages have stale descriptions of [archon] loaded as always-on:

• packages/docs-web/src/content/docs/reference/configuration.md — "Operator log lines" block
• packages/docs-web/src/content/docs/reference/cli.md — boot sequence steps C2/C3
• packages/docs-web/src/content/docs/contributing/cli-internals.md — loadArchonEnv ASCII diagram

Each needs "and ARCHON_VERBOSE_BOOT=1 or LOG_LEVEL=debug/trace is set" added to the condition for the loaded lines.

Also suggest a CHANGELOG.md entry under [Unreleased] ### Fixed:

archon doctor and archon setup no longer interleave [archon] loaded N keys boot lines and Pino info JSON with their checklist output. Set ARCHON_VERBOSE_BOOT=1 or LOG_LEVEL=debug to restore the boot lines; pass --verbose to re-enable structured Pino logs (#1606).

No issues

• Key loading is not affected by the gating — keys are loaded unconditionally, only the stderr line is gated ✓
• isVerboseBoot() is safe: optional chaining on LOG_LEVEL, pure boolean, cannot throw ✓
• setLogLevel runs before any getLog() call in doctor/setup code paths ✓
• ARCHON_VERBOSE_BOOT is a safe env var: equality check only, no interpolation or subprocess exposure ✓
• Test beforeEach/afterEach save/restore is correct for all three env vars ✓
• Type safety is clean throughout ✓

Comprehensive PR Review

PR: #1608 — fix(cli): suppress boot stderr and Pino info logs in archon doctor/setup
Reviewed by: 5 specialized agents (code-review, error-handling, test-coverage, comment-quality, docs-impact)
Date: 2026-05-07

Summary

Small, focused fix that correctly gates [archon] loaded N keys boot-time stderr output behind ARCHON_VERBOSE_BOOT=1 or LOG_LEVEL=debug/trace, and defaults setup/doctor Pino level to warn. Implementation is semantically correct, type-safe, and well-tested for primary paths. No blocking issues.

Verdict: APPROVE — with 2 MEDIUM suggestions worth addressing before merge

🟡 Medium Issues (Consider Fixing Before Merge)

M1: cli.ts comment block exceeds "one short line max" rule

📍 packages/cli/src/cli.ts:285-289

The added 5-line comment block violates CLAUDE.md's "Never write multi-line comment blocks — one short line max" rule. The opening shorthand (quiet > verbose > default) is also slightly inaccurate now that setup/doctor default to warn without any flag.

// Set log level from flags (quiet > verbose > default).
// Interactive commands (setup, doctor) default to warn so their human-readable
// ○/✓ checklist output isn't interleaved with Pino info JSON; --verbose opts
// back into structured logs. Lazy logger initialization in those commands
// means setLogLevel here takes effect before any logger is first created.
const isInteractiveCommand = command === 'setup' || command === 'doctor';

// setup/doctor default to warn to avoid Pino info JSON interleaving with ○/✓ output; lazy loggers pick up this level at first creation
const isInteractiveCommand = command === 'setup' || command === 'doctor';

M2: ARCHON_VERBOSE_BOOT undocumented in configuration reference

📍 packages/docs-web/src/content/docs/reference/configuration.md

The new ARCHON_VERBOSE_BOOT=1 env var has no entry in the docs. Its sister ARCHON_SUPPRESS_NESTED_CLAUDE_WARNING is already documented in the Core env vars table (line ~233). Users troubleshooting silent boot output have no documented way to enable it.

| `ARCHON_VERBOSE_BOOT` | When set to `1`, prints `[archon] loaded N keys from …` lines to stderr at boot. Also enabled by `LOG_LEVEL=debug` or `LOG_LEVEL=trace`. Silent by default to avoid interleaving with interactive command output. | -- |

🟢 Low Issues

✅ What's Good

• Semantic correctness: Keys load unconditionally; only the stderr diagnostic line is gated. Cannot accidentally prevent env vars from loading.
• Consistent naming: ARCHON_VERBOSE_BOOT=1 follows the ARCHON_SUPPRESS_NESTED_CLAUDE_WARNING=1 convention from strip-cwd-env.ts.
• Private encapsulation: isVerboseBoot() is not exported — correct for a boot-only internal helper.
• --quiet still overrides: values.quiet || (isInteractiveCommand && !values.verbose) correctly preserves --quiet as highest-priority flag.
• Test isolation: beforeEach/afterEach save/restore for ARCHON_VERBOSE_BOOT and LOG_LEVEL is clean and consistent with existing ARCHON_HOME handling.
• Key test: "does not emit loaded lines by default even when keys are present" directly validates that suppressing output does not suppress loading — the most critical regression risk.
• No new error paths: All new logic is pure boolean guards; pre-existing process.exit(1) handlers are unchanged and correctly covered.
• No comment rot: The "prints only when N > 0" docblock line was updated to reflect the new gating behavior.

Reviewed by Archon prp-review-agents workflow
Full artifacts: /Users/rasmus/.archon/workspaces/coleam00/Archon/artifacts/runs/fb99fb1302cec1ce6197bae22181e076/review/

⚡ Self-Fix Report (Aggressive)

Status: COMPLETE
Pushed: ✅ Changes pushed to archon/task-fix-issue-1606
Commit: 3b02ce0
Philosophy: Fix everything unless clearly a new concern

Fixes Applied (13 total)

Tests Added

• emits loaded lines when LOG_LEVEL=trace — covers the trace branch of isVerboseBoot()
• does not emit loaded lines when ARCHON_VERBOSE_BOOT is set to a non-"1" value — documents the intentional strict === '1' equality

Skipped (0)

(none — all findings addressed)

Suggested Follow-up Issues

1. "Add resolveLogLevel() helper for testable log-level selection in cli.ts" — main() self-executes on import; unit-testing the isInteractiveCommand branch requires subprocess tests or extracting a pure helper. Pre-existing structural constraint not introduced by this PR.

Validation

✅ Type check | ✅ Lint | ✅ Tests (10 passed)

Self-fix by Archon · aggressive mode · fixes pushed to archon/task-fix-issue-1606