Conversation
Hono's serveStatic passes c.req.path (e.g. '/assets/foo.js') to path.join with the root. When root is absolute, path.join treats the leading slash as an absolute segment and discards root entirely. Add rewriteRequestPath to strip the leading slash so the full path resolves correctly.
…ess.once - Remove stripLeadingSlash — Bun's path.join handles leading slashes correctly - Add existsSync check on webDistPath at startup with log.warn - Switch process.on to process.once for signal handlers in serve.ts - Keep favicon.png explicit route (useful addition)
fix(server): strip leading slash in serveStatic for absolute webDistPath
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Tyone88
pushed a commit
to Tyone88/Archon
that referenced
this pull request
Apr 16, 2026
Release 0.3.5
joaobmonteiro
pushed a commit
to joaobmonteiro/Archon
that referenced
this pull request
Apr 26, 2026
Release 0.3.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 0.3.5
Fixes for
archon serveprocess lifecycle and static file serving.Fixed
archon serveprocess exits immediately: the CLI calledprocess.exit(0)afterstartServer()returned, killing the server. Now blocks on SIGINT/SIGTERM so the server stays running (fix(server): strip leading slash in serveStatic for absolute webDistPath #1047)/favicon.pngroute for the web UIMerging this PR releases 0.3.5 to main.