fix: Promise.any race condition in validator script check (#1007) by Wirasm · Pull Request #1010 · coleam00/Archon

Wirasm · 2026-04-09T16:41:43Z

Summary

validateWorkflowResources used Promise.any to check if a named script file exists, but fileExists always fulfills (never rejects), so Promise.any returned the first resolved value regardless of truthiness — a race condition that flaked on Windows CI
Replaced with Promise.all + .some(Boolean) which is deterministic

Changes

File	Change
`packages/workflows/src/validator.ts`	Replace `Promise.any` with `Promise.all` + `.some()`

Testing

Type check passes
All 35 validator tests pass
Full bun run validate passes (0 failures across all packages)
Lint + format clean

Validation

bun run validate

Fixes #1007

Summary by CodeRabbit

Documentation
- Added investigation documentation outlining workflow operation improvements, including approval gate enhancements, artifact directory handling updates, and CLI conversation continuity improvements.
Refactor
- Improved internal script validation logic for better resource checking.

…1007) Promise.any resolves with the first fulfilled promise regardless of value. Since fileExists always fulfills (never rejects), Promise.any could return false even when a later extension check would return true — a race condition that flaked on Windows CI. Fixes #1007

coderabbitai · 2026-04-09T16:42:00Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a5628d4b-01a1-4347-b6b5-0e196014b1ff

📥 Commits

Reviewing files that changed from the base of the PR and between 0d1ff41 and 9e868dd.

📒 Files selected for processing (2)

.claude/PRPs/issues/issue-1001-1002-1003.md
packages/workflows/src/validator.ts

📝 Walkthrough

Walkthrough

The PR introduces comprehensive documentation describing bug root causes and fixes and corrects a timing-dependent test flake in the workflow validator by replacing Promise.any() with Promise.all() for checking script file existence across multiple extensions.

Changes

Cohort / File(s)	Summary
Documentation `.claude/PRPs/issues/issue-1001-1002-1003.md`	New investigation document detailing three workflow bug root causes: approval gate metadata capture, artifact directory access, and CLI conversation ID propagation; includes step-by-step fix implementation, test commands, and edge-case handling guidance.
Bug Fix `packages/workflows/src/validator.ts`	Replaced `Promise.any(...).catch()` race condition with `Promise.all(...)` aggregation followed by `.some(Boolean)` to reliably check if named script files exist across multiple extensions, eliminating Windows CI timing flake.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related issues

fix(workflows): interactive-prd generate node writes to .claude/ which is blocked #1002: Directly addresses the workflow bug fix documented in the PRD (updating interactive-prd generate/validate nodes to use $ARTIFACTS_DIR instead of blocked .claude/ path); implementation may span across this and related PRs.

Possibly related PRs

feat: script node type for DAG workflows (bun/uv runtimes) #999: Modifies validateWorkflowResources in the same file (packages/workflows/src/validator.ts); direct code-level overlap in the script existence-check logic.

Poem

🐰 A race once stirred on Windows bright,
Where promises would flip the fight—
Now all resolve before we deem,
No more a timely, flickering dream! ✨

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/issue-1007-promise-any-race

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Wirasm · 2026-04-09T16:42:28Z

Code Review

Verdict: PASS — no issues found.

The root cause diagnosis is correct: fileExists always fulfills (catches access() rejection internally, returns false), so Promise.any resolves with the first settled value regardless of truthiness. On Windows CI where .js can settle before .ts, this returns false even when the .ts file exists.

The fix (Promise.all + .some(Boolean)) is minimal, correct, and deterministic. The removed .catch(() => false) was dead code since fileExists never rejects. Single-extension paths (uv runtime) are unaffected.

No edge cases missed, no regressions introduced.

) * Investigate issues #1001, #1002, #1003: interactive-prd workflow bugs * fix: replace Promise.any with Promise.all in validator script check (#1007) Promise.any resolves with the first fulfilled promise regardless of value. Since fileExists always fulfills (never rejects), Promise.any could return false even when a later extension check would return true — a race condition that flaked on Windows CI. Fixes #1007

…fix-dag-bash-validation Fix DAG validation emitting wrong error for empty bash/prompt nodes

) (coleam00#1010) * Investigate issues coleam00#1001, coleam00#1002, coleam00#1003: interactive-prd workflow bugs * fix: replace Promise.any with Promise.all in validator script check (coleam00#1007) Promise.any resolves with the first fulfilled promise regardless of value. Since fileExists always fulfills (never rejects), Promise.any could return false even when a later extension check would return true — a race condition that flaked on Windows CI. Fixes coleam00#1007

…fix-dag-bash-validation Fix DAG validation emitting wrong error for empty bash/prompt nodes

) (coleam00#1010) * Investigate issues coleam00#1001, coleam00#1002, coleam00#1003: interactive-prd workflow bugs * fix: replace Promise.any with Promise.all in validator script check (coleam00#1007) Promise.any resolves with the first fulfilled promise regardless of value. Since fileExists always fulfills (never rejects), Promise.any could return false even when a later extension check would return true — a race condition that flaked on Windows CI. Fixes coleam00#1007

Wirasm added 2 commits April 9, 2026 19:36

Investigate issues #1001, #1002, #1003: interactive-prd workflow bugs

1c7fd9e

Wirasm merged commit 2994d56 into dev Apr 9, 2026
2 of 4 checks passed

Wirasm deleted the fix/issue-1007-promise-any-race branch April 9, 2026 16:42

imagicrafter pushed a commit to imagicrafter/archon that referenced this pull request Apr 9, 2026

Merge pull request coleam00#1010 from dynamous-community/archon/task-…

88ce786

…fix-dag-bash-validation Fix DAG validation emitting wrong error for empty bash/prompt nodes

Wirasm mentioned this pull request Apr 10, 2026

Release 0.3.3 #1043

Merged

Tyone88 pushed a commit to Tyone88/Archon that referenced this pull request Apr 16, 2026

Merge pull request coleam00#1010 from dynamous-community/archon/task-…

b812ea0

…fix-dag-bash-validation Fix DAG validation emitting wrong error for empty bash/prompt nodes

joaobmonteiro pushed a commit to joaobmonteiro/Archon that referenced this pull request Apr 26, 2026

Merge pull request coleam00#1010 from dynamous-community/archon/task-…

2b5793a

…fix-dag-bash-validation Fix DAG validation emitting wrong error for empty bash/prompt nodes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Promise.any race condition in validator script check (#1007)#1010

fix: Promise.any race condition in validator script check (#1007)#1010
Wirasm merged 2 commits into
devfrom
fix/issue-1007-promise-any-race

Wirasm commented Apr 9, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 9, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related issues

Possibly related PRs

Poem

Uh oh!

Wirasm commented Apr 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Wirasm commented Apr 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Testing

Validation

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related issues

Possibly related PRs

Poem

Uh oh!

Wirasm commented Apr 9, 2026

Code Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Wirasm commented Apr 9, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 9, 2026 •

edited

Loading