[Breaking Change] Update RequiredIf Validator to Accept UDF/Closure and Update UDF Validator for Consistency When Handling Null/Empty Values#78
Closed
homestar9 wants to merge 4 commits intocoldbox-modules:developmentfrom
Conversation
homestar9
added a commit
to homestar9/cbvalidation-docs
that referenced
this pull request
Sep 8, 2023
Update `requireIf` validator to include option to pass a UDF/closure. (coldbox-modules/cbvalidation#78)
This is a breaking change designed to make the UDF validator consistent with other validators as discussed here (ortus-docs/cbvalidation-docs#13). Developers should switch to the `requiredIf` validator if they need to dynamically evaluate whether a field should be required or not.
dfc0b96 to
620072c
Compare
RequiredIf Validator to Accept UDF/ClosureRequiredIf Validator to Accept UDF/Closure and Update UDF Validator for Consistency
RequiredIf Validator to Accept UDF/Closure and Update UDF Validator for ConsistencyRequiredIf Validator to Accept UDF/Closure and Update UDF Validator for Consistency When Handling Null/Empty Values
RequiredIf Validator to Accept UDF/Closure and Update UDF Validator for Consistency When Handling Null/Empty ValuesRequiredIf Validator to Accept UDF/Closure and Update UDF Validator for Consistency When Handling Null/Empty Values
Contributor
Author
|
This would be better if broken up into two pull requests. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds additional functionality to the
RequiredIfvalidator. Now, you can pass a UDF/closure to the validator to dynamically evaluate whether the field is required or not. The UDF/closure should returntrueif the field is required andfalseif not.Example:
The
UDFvalidator was also updated for consistency (see ortus-docs/cbvalidation-docs#13) and will treat null/empty values as valid. Developers who want to dynamically determine whether a field should be required will need to switch to usingRequiredIf. This is a BREAKING change and should be reserved for the next major version of CBValidation.