Closed
Conversation
dirk-thomas
reviewed
Jul 19, 2018
| 'share/{pkg.name}/local_setup.bat'.format_map(locals()), | ||
| 'share/{pkg.name}/local_setup.ps1'.format_map(locals()), | ||
| 'share/{pkg.name}/local_setup.sh'.format_map(locals()), | ||
| 'share/{pkg.name}/local_setup.zsh'.format_map(locals()), |
Member
There was a problem hiding this comment.
Since this package doesn't depend on zsh I would rather not hard code this here. The same problem is already the case for bash / powershell.
See #29 for an alternative approach.
Author
There was a problem hiding this comment.
Yeah I agree it didn't seem appropriate that this package was hard coding without depending on the shell specific packages (like colcon-powershell or colcon-zsh)
Author
|
closing in favor of more generic logic from #29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
possible fix for colcon/colcon-zsh#12.
Though there may be other things to change for zsh to work as expected
@wjwwood FYI