Skip to content

Conversation

@sebweb3r
Copy link
Contributor

Two common mistakes of my group

Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment

disinguish->distinguish
disiplined->disciplined
disired->desired
diskretization->discretization
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the sation variant as a separate typo please.

Also the Wikipedia page mentions discretized, so it might be worth adding this typo against that word and maybe also discrete, discretely, discretion etc. Possibly also discuss etc (although grep.app doesn't find examples of the latter).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some of your suggestions. I think I will make/lookup a list of commonly misspelled words by germans and add it in my holidays.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peternewman i don't understand the travis checks.
f.e. diskretization is for sure not in aspell, since it is wrong.
or https://en.wiktionary.org/wiki/discretise exists :-)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some of your suggestions. I think I will make/lookup a list of commonly misspelled words by germans and add it in my holidays.

Great, the trick there is probably to add a new dictionary called dictionary-de.txt and if necessary move anything in the main dictionary that's a valid German word (like some of my other suggestions) out into a dictionary-en.txt (and make that default). Then ideally make Travis check all that complication too!

@peternewman i don't understand the travis checks.
f.e. diskretization is for sure not in aspell, since it is wrong.
or https://en.wiktionary.org/wiki/discretise exists :-)

See my comments for some further explanation.

@peternewman peternewman added the dictionary Changes to the dictionary label Jul 20, 2020
Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, it seems my suggestions are ahead of where we are in terms of practicality.

@peternewman peternewman merged commit 5204d36 into codespell-project:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dictionary Changes to the dictionary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants