🤖 fix: terminal input broken by inverted key handler return values #1586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1985d4 to
4987e7a
Compare
The attachCustomKeyEventHandler in ghostty-web returns: - true: PREVENT default handling (we handled it) - false: ALLOW default handling (let ghostty process it) The clipboard shortcut handler (#1563) had this inverted, returning true for all non-keydown events and at the end of the handler, which prevented ghostty from processing any keyboard input. Fixes terminal input regression introduced in d3928b5.
4987e7a to
86f6f24
Compare
Collaborator
Author
|
/retest |
ammar-agent
added a commit
that referenced
this pull request
Jan 13, 2026
Adds end-to-end tests that verify keyboard input reaches the terminal, preventing regression of the bug fixed in PR #1586. The bug: attachCustomKeyEventHandler returned inverted values, causing ghostty-web to block all keyboard input (characters, Enter, arrows, etc.) instead of only clipboard shortcuts. Tests verify: - Characters can be typed and commands executed - Special keys (Enter, Backspace, Tab, arrows) work correctly - The terminal doesn't freeze when receiving keyboard input Also adds helper methods to the E2E UI utils for terminal interaction: - focusTerminal() - typeInTerminal() - pressKeyInTerminal() - runTerminalCommand()
ammario
pushed a commit
that referenced
this pull request
Jan 13, 2026
…#1590) ## Summary Adds end-to-end tests that verify keyboard input reaches the terminal, preventing regression of the bug fixed in PR #1586. ## Root Cause (from #1586) The bug in `attachCustomKeyEventHandler` had inverted return values: - ghostty-web expects `true` to PREVENT default, `false` to ALLOW default - The buggy code returned `true` for all non-clipboard keys, blocking ALL input ## Tests Added 1. **`keyboard input reaches terminal`** - Types a command that creates a marker file and verifies execution 2. **`special keys work in terminal`** - Tests Enter, Backspace, Tab, and arrow keys ## Helper Methods Added New E2E UI utils for terminal interaction: - `focusTerminal()` - `typeInTerminal(text)` - `pressKeyInTerminal(key)` - `runTerminalCommand(command)` --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high` • Cost: `$2.96`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes terminal input regression introduced in #1563 (d3928b5).
Root Cause
The
attachCustomKeyEventHandlerin ghostty-web returns:true: PREVENT default handling (we handled it)false: ALLOW default handling (let ghostty process it)The clipboard shortcut handler had this inverted:
truefor all non-keydown events → blocked keyup/keypresstrueat end of handler → blocked all normal key inputThis effectively disabled all terminal input except the specific copy/paste shortcuts.
Fix
Invert all return values to match ghostty-web's API contract.
Generated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high• Cost:$2.53