fix: Start SFTP sessions in user home (working directory)#4549
Merged
Conversation
This commit switches to our fork of `pkg/sftp` which includes a Server option for changing the current working directory. Attempt to upstream: pkg/sftp#528 Supercedes and closes #4420 Fixes #3620
adfa45e to
974c707
Compare
deansheather
approved these changes
Oct 14, 2022
deansheather
left a comment
Member
There was a problem hiding this comment.
The fork should be moved to the coder org so other engineers can contribute to it if necessary.
Member
Author
Hoping the fork will be short-lived. But I can do that if it isn’t merged in the coming days 👍 |
Member
|
Merging this to fix a user issue! @mafredri if there's something you need to add still, lets just do it in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit switches to our fork of
pkg/sftpwhich includes a Serveroption for changing the current working directory.
Attempt to upstream: pkg/sftp#528
Supercedes and closes #4420
Fixes #3620