feat: use v2 API for agent metadata updates #12281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
spikecurtis
commented
Feb 23, 2024
| // we're only interested about up-to-date values. | ||
| updatedMetadata[mr.key] = mr.result | ||
| continue | ||
| case err := <-reportError: |
Contributor
Author
There was a problem hiding this comment.
FYI: I moved this up to the main select so that if there is an error, we won't wait around until the next tick to exit.
359baae to
ce4323c
Compare
ce4323c to
ab6a2a5
Compare
mafredri
approved these changes
Feb 23, 2024
Member
mafredri
left a comment
There was a problem hiding this comment.
Minor nits but otherwise LGTM!
ab6a2a5 to
e06b9b7
Compare
Contributor
Author
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the agent to report metadata over the v2 API.
Fixes #10534