Skip to content

feat: add version of Code OSS to output#4925

Merged
jawnsy merged 6 commits intomainfrom
jawnsy/feat-add-code-version
Mar 1, 2022
Merged

feat: add version of Code OSS to output#4925
jawnsy merged 6 commits intomainfrom
jawnsy/feat-add-code-version

Conversation

@jawnsy
Copy link

@jawnsy jawnsy commented Feb 28, 2022 •
edited
Loading

Show the bundled version of Code OSS in the text-based output
for --version and --help, in addition to the JSON output
(--version --json)

Closes: #4874

Help output:

$ node . --help
code-server 4.0.2 development with Code 1.63.0

Usage: code-server [options] [path]
    - Opening a directory: code-server ./path/to/your/project
    - Opening a saved workspace: code-server ./path/to/your/project.code-workspace

Output of --version:

$ node . --version
4.0.2 development with Code 1.63.0

Output of --version --json:

$ node . --version --json
{"codeServer":"4.0.2","commit":"development","vscode":"1.63.0"}

feat: add version of Code OSS to output
887ae97 
Show the bundled version of Code OSS in the text-based output
for --version and --help, in addition to the JSON output
(--version --json)

Closes: #4874
@jawnsy jawnsy temporarily deployed to CI February 28, 2022 23:24 Inactive
@jawnsy jawnsy temporarily deployed to CI February 28, 2022 23:29 Inactive
@github-actions
Copy link

github-actions bot commented Feb 28, 2022 •
edited
Loading

✨ Coder.com for PR #4925 deployed! It will be updated on every commit.

@jawnsy jawnsy temporarily deployed to npm February 28, 2022 23:38 Inactive
@codecov
Copy link

codecov bot commented Feb 28, 2022 •
edited
Loading

Codecov Report

Merging #4925 (8b6a45f) into main (506d3f4) will not change coverage.
The diff coverage is 20.00%.

❗ Current head 8b6a45f differs from pull request most recent head 8fac22e. Consider uploading reports for the commit 8fac22e to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4925   +/-   ##
=======================================
  Coverage   70.02%   70.02%           
=======================================
  Files          29       29           
  Lines        1658     1658           
  Branches      364      364           
=======================================
  Hits         1161     1161           
  Misses        423      423           
  Partials       74       74
Impacted Files Coverage Δ
src/node/entry.ts 0.00% <0.00%> (ø)
src/node/constants.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506d3f4...8fac22e. Read the comment docs.

@jawnsy jawnsy self-assigned this Mar 1, 2022
@jawnsy jawnsy temporarily deployed to CI March 1, 2022 17:53 Inactive
@jawnsy jawnsy temporarily deployed to CI March 1, 2022 17:55 Inactive
@jawnsy jawnsy temporarily deployed to npm March 1, 2022 18:04 Inactive
@jawnsy jawnsy marked this pull request as ready for review March 1, 2022 19:18
@jawnsy jawnsy requested a review from a team March 1, 2022 19:18
@jawnsy jawnsy temporarily deployed to CI March 1, 2022 19:18 Inactive
@jawnsy jawnsy temporarily deployed to npm March 1, 2022 19:27 Inactive
@jsjoeio jsjoeio added the feature New user visible feature label Mar 1, 2022
jsjoeio
jsjoeio approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jawnsy jawnsy merged commit 2c78577 into main Mar 1, 2022
@jawnsy jawnsy deleted the jawnsy/feat-add-code-version branch March 1, 2022 20:20
@jsjoeio jsjoeio mentioned this pull request Mar 15, 2022
Closed
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
@TinLe
feat: add version of Code OSS to output (coder#4925)
23f98c6 
Show the bundled version of Code OSS in the text-based output
for --version and --help, in addition to the JSON output
(--version --json)

Closes: coder#4874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jsjoeio jsjoeio jsjoeio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jawnsy jawnsy

Labels

feature New user visible feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feat]: Add VS Code version number to --version output

2 participants

@jawnsy @jsjoeio