feat: add version string functions to constants#4920
Merged
Conversation
Introduce helper functions for getting human- and machine-readable version strings from the constants package, and cover it in unit tests. This is a first step to resolving #4874.
jawnsy
commented
Feb 26, 2022
|
✨ Coder.com for PR #4920 deployed! It will be updated on every commit.
|
Codecov Report
@@ Coverage Diff @@
## main #4920 +/- ##
==========================================
+ Coverage 69.86% 69.96% +0.10%
==========================================
Files 29 29
Lines 1649 1655 +6
Branches 363 364 +1
==========================================
+ Hits 1152 1158 +6
Misses 423 423
Partials 74 74
Continue to review full report at Codecov.
|
jawnsy
commented
Feb 26, 2022
TinLe
pushed a commit
to TinLe/code-server
that referenced
this pull request
Apr 23, 2022
Introduce helper functions for getting human- and machine-readable version strings from the constants package, and cover it in unit tests. This is a first step to resolving coder#4874.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce helper functions for getting human- and machine-readable
version strings from the constants package, and cover it in unit
tests.
This is a first step to resolving #4874.