style: cookie doman => cookie domain#4919
Merged
jsjoeio merged 2 commits intocoder:mainfrom Mar 1, 2022
edvincent:cookie-domain-typo
Merged
style: cookie doman => cookie domain#4919jsjoeio merged 2 commits intocoder:mainfrom edvincent:cookie-domain-typo
jsjoeio merged 2 commits intocoder:mainfrom
edvincent:cookie-domain-typo
Conversation
jsjoeio
approved these changes
Feb 28, 2022
Contributor
jsjoeio
left a comment
There was a problem hiding this comment.
This made me laugh 😂 whoops. Thanks for fixing!
Codecov Report
@@ Coverage Diff @@
## main #4919 +/- ##
=======================================
Coverage 69.96% 69.96%
=======================================
Files 29 29
Lines 1655 1655
Branches 364 364
=======================================
Hits 1158 1158
Misses 423 423
Partials 74 74
Continue to review full report at Codecov.
|
TinLe
pushed a commit
to TinLe/code-server
that referenced
this pull request
Apr 23, 2022
Co-authored-by: Joe Previte <jjprevite@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While troubleshooting #4900, we got a nice smile from this typo ;)