feat: add tests for node/settings.ts#4717
Merged
repo-ranger[bot] merged 1 commit intomainfrom Jan 10, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4717 +/- ##
==========================================
+ Coverage 69.10% 69.23% +0.12%
==========================================
Files 29 29
Lines 1638 1638
Branches 341 341
==========================================
+ Hits 1132 1134 +2
+ Misses 430 428 -2
Partials 76 76
Continue to review full report at Codecov.
|
792134e to
386bf29
Compare
code-asher
approved these changes
Jan 10, 2022
Member
code-asher
left a comment
There was a problem hiding this comment.
Looks great! I only have architectural comments.
code-asher
reviewed
Jan 10, 2022
|
✨ Coder.com for PR #4717 deployed! It will be updated on every commit.
|
386bf29 to
7000239
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds additional tests for
node/settings.tsto ensure we log warnings when expected.Context
The
SettingsProviderprovides the application with access to the settings for code-server. This is then added to all routes underreq.settingsso they can easily access it. We're adding tests to ensure that our logger does indeed log warnings when something goes wrong.Screenshots
Before
After
Fixes N/A
#TestingMondays