Skip to content

release: 4.0.0#4597

Merged
jsjoeio merged 2 commits intomainfrom
v4.0.0
Dec 10, 2021
Merged

release: 4.0.0#4597
jsjoeio merged 2 commits intomainfrom
v4.0.0

Conversation

@jsjoeio
Copy link
Copy Markdown
Contributor

@jsjoeio jsjoeio commented Dec 9, 2021 •
edited
Loading

This PR is to generate a new release of code-server at 4.0.0.

Screenshot

image

TODOs

Since this is a major release with breaking changes, we need to take extra steps to test it.

How to Test

  1. Wait for CI to finish.
  2. Download artifcat: release-packages
  3. Untar locally:
# Linux
cd release-packages && tar -xzf code-server*-linux-amd64.tar.gz
# macOS
cd release-packages && tar -xzf code-server*-macos-amd64.tar.gz
  1. Run locally:
# Linux
./code-server*-linux-amd64.tar.gz./code-server
#macOS
./code-server*-macos-amd64.tar.gz/code-server

Before Release

After Release

  • publish release and merge PR
  • update the AUR package this is a pre-release which means released to GitHub only so no npm, docker or aur packages will be updated

Fixes #4176

@jsjoeio jsjoeio self-assigned this Dec 9, 2021
@jsjoeio jsjoeio requested a review from a team December 9, 2021 20:43
@jsjoeio jsjoeio modified the milestone: 4.0.0 Dec 9, 2021
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 9, 2021 •
edited
Loading

✨ Coder.com for PR #4597 deployed! It will be updated on every commit.

@jsjoeio jsjoeio marked this pull request as ready for review December 9, 2021 20:53
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 9, 2021 •
edited
Loading

Codecov Report

Merging #4597 (c55f0e8) into main (9e583fa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4597   +/-   ##
=======================================
  Coverage   66.14%   66.14%           
=======================================
  Files          30       30           
  Lines        1654     1654           
  Branches      331      331           
=======================================
  Hits         1094     1094           
  Misses        475      475           
  Partials       85       85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e583fa...c55f0e8. Read the comment docs.

@jsjoeio
Copy link
Copy Markdown
Contributor Author

jsjoeio commented Dec 9, 2021

It appears we have lost our patch for changing the display language. Opened an issue to track: #4598

@jsjoeio
Copy link
Copy Markdown
Contributor Author

jsjoeio commented Dec 9, 2021

GitHub Auth works!

How I tested:

  1. Install GitHub Pull Requests and Issues Extension
  2. Sign in using PAT
  3. Create PR

@bpmct
Copy link
Copy Markdown
Member

bpmct commented Dec 9, 2021

bugs found:

  • code-server [foldername] or code-server -r [foldername] does not work to open a folder. strangely, it works fine with files
  • popular extensions are not recommended if user has 0 extensions installed (3.12.0 seemed to unfold this tab)
    Screen Shot 2021-12-09 at 2 49 25 PM

Everything else works great. Tested on OSX

@jsjoeio jsjoeio mentioned this pull request Dec 10, 2021
Closed
@jsjoeio
Copy link
Copy Markdown
Contributor Author

jsjoeio commented Dec 10, 2021

code-server [foldername] or code-server -r [foldername] does not work to open a folder. strangely, it works fine with files

Great catch by @bpmct! @code-asher fixed this in #4599

popular extensions are not recommended if user has 0 extensions installed (3.12.0 seemed to unfold this tab)

Tracking here: #4600

@jsjoeio jsjoeio merged commit c77999b into main Dec 10, 2021
@jsjoeio jsjoeio deleted the v4.0.0 branch December 10, 2021 20:30
@jsjoeio jsjoeio restored the v4.0.0 branch December 10, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

@jsjoeio jsjoeio

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

release: 4.0.0

3 participants

@jsjoeio @bpmct @code-asher