Fix helm chart for extraConfigmapMounts#4497
Merged
jsjoeio merged 1 commit intocoder:mainfrom Nov 12, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4497 +/- ##
=======================================
Coverage 66.46% 66.46%
=======================================
Files 30 30
Lines 1625 1625
Branches 330 330
=======================================
Hits 1080 1080
Misses 463 463
Partials 82 82 Continue to review full report at Codecov.
|
jsjoeio
approved these changes
Nov 12, 2021
Contributor
jsjoeio
left a comment
There was a problem hiding this comment.
LGTM! Thank you so much!
Contributor
Author
|
Thanks! |
GirlBossRush
pushed a commit
that referenced
this pull request
Nov 15, 2021
GirlBossRush
pushed a commit
that referenced
this pull request
Nov 15, 2021
* Refactor vscode router to load async. * Bump vscode. * fix volumes (#4497) * Fix : recreate the termux guide to adapt the recent changes (#4472) * Fix : recreate the termux guide to adapt the recent changes Termux nodejs-lts changed from v14 to v16 and there are many issues people are facing such as with argon2. Hence I recommend changing it to this install process which is comparably better and has one less issue :^) I've also added some extra things such as installing GO and Python, idk about the TOC tree but this is pretty much it. * yarn-fmt and minor typos #4472 (comment) * Fix : replace unnecessary steps to be linked to a guide * Change from private gist to a section in Extra * Remove reference to non-existent step * ready to merge! Co-authored-by: Joe Previte <jjprevite@gmail.com> Co-authored-by: Jinu <jlandowner8@gmail.com> Co-authored-by: Han Seung Min - 한승민 <hanseungmin.ar@gmail.com> Co-authored-by: Joe Previte <jjprevite@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4496