Merged
Conversation
b105b77 to
235465c
Compare
I added the missing versions and some changelog entries for the latest version. I also added some extra details to the entries that should help users understand what changed and what they need to do about it. The overall format is based on keepachangelog.com. In that same spirit I removed entries that do not affect users (documentation and development changes). I removed the names because it seems unlikely users will be interested, that information can be found in the PR, and code is really the work of multiple developers (even if only one is writing code and the other is reviewing) which is not something that is reflected in this document.
235465c to
69b7807
Compare
Codecov Report
@@ Coverage Diff @@
## main #4492 +/- ##
=======================================
Coverage 66.46% 66.46%
=======================================
Files 30 30
Lines 1625 1625
Branches 330 330
=======================================
Hits 1080 1080
Misses 463 463
Partials 82 82 Continue to review full report at Codecov.
|
jsjoeio
approved these changes
Nov 10, 2021
Contributor
jsjoeio
left a comment
There was a problem hiding this comment.
I'm all for this! I agree, they can find the user in the PR (and PRs have multiple authors as you mentioned). Seems like a step forward for us! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the missing versions and some changelog entries for the latest
version. I also added some extra details to the entries that should
help users understand what changed and what they need to do about
it. The overall format is based on keepachangelog.com.
In that same spirit I removed entries that do not affect
users (documentation and development changes).
I removed the names because it seems unlikely users will be interested,
that information can be found in the PR, and code is really the work of
multiple developers (even if only one is writing code and the other is
reviewing) which is not something that is reflected in this document.
Please feel free to debate the changes!